Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor gardener@1.71.0 and adapt changes for workerless Shoots #189

Merged
merged 10 commits into from
May 23, 2023
Merged

Vendor gardener@1.71.0 and adapt changes for workerless Shoots #189

merged 10 commits into from
May 23, 2023

Conversation

acumino
Copy link
Member

@acumino acumino commented May 17, 2023 •
edited

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:

  • Vendor gardener v1.71.0

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The following dependency has been updated:
  - github.com/gardener/gardener 1.67.1 -> 1.71.0

@acumino acumino requested review from a team as code owners May 17, 2023 18:30
@gardener-robot gardener-robot added needs/review Needs review area/networking Networking related kind/enhancement Enhancement, improvement, extension size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels May 17, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 17, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 17, 2023
@acumino acumino mentioned this pull request May 17, 2023
Closed
31 tasks
@acumino
Copy link
Member Author

acumino commented May 18, 2023

/invite @ScheererJ

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 18, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 18, 2023
ScheererJ
ScheererJ reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.

I just have one question.

pkg/admission/mutator/webhook.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels May 23, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 23, 2023
@gardener-robot gardener-robot removed the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label May 23, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 23, 2023
@acumino acumino changed the title Vendor gardener@1.70.2 and adapt changes for workerless Shoots Vendor gardener@1.71.0 and adapt changes for workerless Shoots May 23, 2023
DockToFuture
DockToFuture approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels May 23, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 23, 2023
@DockToFuture DockToFuture merged commit b83ae83 into gardener:master May 23, 2023
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 23, 2023
@acumino acumino deleted the vendor/gardener@1.70.2 branch May 23, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ left review comments

@DockToFuture DockToFuture DockToFuture approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@acumino @DockToFuture @ScheererJ @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot