Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casing of l7 proxy configuration to enable it by default #261

Merged
merged 1 commit into from Mar 21, 2024

Conversation

ScheererJ
Copy link
Contributor

@ScheererJ ScheererJ commented Mar 20, 2024

How to categorize this PR?

/area networking
/kind bug

What this PR does / why we need it:
Fix casing of l7 proxy configuration to enable it by default.

Which issue(s) this PR fixes:
Fixes #257.

Special notes for your reviewer:
The usage of this helm option


was using l7Proxy while it was introduced with the cilium 1.9.4 update as l7proxy in the configuration:

Release note:

Cilium configuration option `enable-l7-proxy` is now enabled per default.

@ScheererJ ScheererJ requested review from a team as code owners March 20, 2024 16:43
@gardener-robot gardener-robot added needs/review Needs review area/networking Networking related kind/bug Bug size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 20, 2024
@axel7born
Copy link
Contributor

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 20, 2024
Copy link

gardener-prow bot commented Mar 20, 2024

@ScheererJ: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-extension-networking-cilium-e2e-kind 5834efe link true /test pull-extension-networking-cilium-e2e-kind

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ScheererJ ScheererJ merged commit 6f7b3eb into gardener:master Mar 21, 2024
7 of 8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could I enable the gatewayAPI feauther?
4 participants