Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the disablement of the reverse path filter so that it works better across operating systems. #84

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

ScheererJ
Copy link
Contributor

How to categorize this PR?

/area networking
/kind bug

What this PR does / why we need it:
Improved the disablement of the reverse path filter so that it works better across operating systems.

Some operating systems include sysctl configurations not only in /etc/sysctl.d, but also in the /usr tree.
It is easier and safer to simply add a configuration template disabling the reverse path filter altogether.

Which issue(s) this PR fixes:
Fixes issues with https://github.com/gardener/gardener-extension-os-suse-chost setting rp_filter in non /etc configuration files.

Special notes for your reviewer:

Release note:

Disables rp_filter properly when running cilium on all operating systems

…better across operating systems.

Some operating systems include sysctl configurations not only in /etc/sysctl.d, but also in the /usr tree.
It is easier and safer to simply add a configuration template disabling the reverse path filter altogether.
@ScheererJ ScheererJ requested review from a team as code owners March 1, 2022 13:51
@gardener-robot gardener-robot added area/networking Networking related kind/bug Bug labels Mar 1, 2022
@gardener-robot
Copy link

@ScheererJ Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 1, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 1, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 1, 2022
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 1, 2022
@ScheererJ ScheererJ merged commit bf99464 into gardener:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants