Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners from STACKIT #96

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

timebertt
Copy link
Member

@timebertt timebertt commented Mar 27, 2024

How to categorize this PR?

/area os open-source
/kind enhancement

What this PR does / why we need it:

At STACKIT, we offer flatcar as the primary OS for worker nodes. Hence, we rely on this extension.
As other interested parties faced out CoreOS/flatcar in their environments, we probably have the highest stakes in keeping this extension up-to-date.
To simplify things, this PR adds two codeowners from STACKIT (particular persons are not set in stone).
This allows us to formally assume responsibility for this repository.

TODO:

Which issue(s) this PR fixes:

See https://gardener-cloud.slack.com/archives/C045DSWJZB9/p1711461148599709

Special notes for your reviewer:

I recall, that we cannot add contributors from outside SAP to the gardener org. With this, we cannot add STACKIT colleagues to the @gardener/gardener-extension-os-coreos-maintainers group.
If this has changed meanwhile, let me know and we can drop this PR and use the group instead.

Release note:

NONE

@timebertt timebertt requested review from a team as code owners March 27, 2024 19:46
@gardener-robot gardener-robot added the needs/review Needs review label Mar 27, 2024
@gardener-robot-ci-1
Copy link
Contributor

Thank you @timebertt for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/os Operation system related kind/enhancement Enhancement, improvement, extension labels Mar 27, 2024
@gardener-robot
Copy link

@timebertt Thank you for your contribution.

@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Mar 27, 2024
@timebertt
Copy link
Member Author

/ok-to-test

@gardener-robot
Copy link

@timebertt You are not permitted to touch label reviewed/ok-to-test.

@timebertt
Copy link
Member Author

/ok-to-test

@gardener-robot
Copy link

@timebertt You are not permitted to touch label reviewed/ok-to-test.

@timebertt
Copy link
Member Author

@zkdev Now that @dergeberl and I are part of @gardener, we could also use the @gardener/gardener-extension-os-coreos-maintainers team instead of adding our usernames to CODEOWNERS. Then we could drop this PR.
WDYT?

@zkdev
Copy link
Member

zkdev commented Mar 28, 2024

I prefer to explicitly mention you, next to core-os GitHub team, in CODEOWNERS file to avoid unintended side-effects.

@timebertt
Copy link
Member Author

Ok, fine for me 👍

@timebertt
Copy link
Member Author

/ok-to-test

@gardener-robot
Copy link

@timebertt You are not permitted to touch label reviewed/ok-to-test.

@timebertt
Copy link
Member Author

@timebertt You are not permitted to touch label reviewed/ok-to-test.

Is this bound to the CODEOWNERS file? Or are we missing anything else?

@timebertt timebertt added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 2, 2024
@ci-shared-oss-pipeline-0 ci-shared-oss-pipeline-0 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 2, 2024
@plkokanov
Copy link
Contributor

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 2, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 2, 2024
@timebertt timebertt merged commit b80b95d into gardener:master Apr 2, 2024
5 checks passed
@timebertt timebertt deleted the codeowners branch April 2, 2024 15:03
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/os Operation system related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants