Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enh/transmit unencoded #29

Merged
merged 3 commits into from May 21, 2021
Merged

Enh/transmit unencoded #29

merged 3 commits into from May 21, 2021

Conversation

BeckerMax
Copy link
Contributor

@BeckerMax BeckerMax commented Apr 20, 2021 •
edited

Accepts the flag Transmit Unencoded.

Needed for creation of bootstrap-tokens for machines introduced here: gardener/gardener#3902

How to categorize this PR?
/area security
/kind enhancement
/os garden-linux

What this PR does / why we need it:
See gardener/gardener#3898 and gardener/gardener#3902

Release note:

Introduces new flag `TransmitUnencoded` which writes file content unencoded into the worker resource.

@BeckerMax BeckerMax requested a review from a team as a code owner April 20, 2021 13:11
@gardener-robot gardener-robot added area/security Security related kind/enhancement Enhancement, improvement, extension os/garden-linux Related to Garden Linux OS needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Apr 20, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 20, 2021
@BeckerMax BeckerMax mentioned this pull request Apr 20, 2021
Closed
10 tasks
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 20, 2021
@BeckerMax BeckerMax mentioned this pull request Apr 20, 2021
Merged
@BeckerMax BeckerMax marked this pull request as draft April 20, 2021 13:16
@BeckerMax
Copy link
Contributor Author

If you want to test this PR here is a image with this version:
eu.gcr.io/gardener-project/gardener/extensions/os-gardenlinux:v0.9.0-dev-mb.3
Remember to also update the helm chart in the controllerregistration (helm chart changed independently of this PR).

@rfranzke
Copy link
Member

/rebase

@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Apr 26, 2021
@gardener-robot gardener-robot added size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) and removed needs/rebase Needs git rebase size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels May 12, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 12, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 12, 2021
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 17, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 17, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 17, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 17, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 17, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 17, 2021
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels May 17, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 17, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 17, 2021
@rfranzke
Copy link
Member

#3902 got merged, please revendor it and mark this PR as 'ready for review'

@rfranzke
Copy link
Member

/invite @vpnachev

@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 19, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 19, 2021
@BeckerMax
Copy link
Contributor Author

/squash

@gardener-robot gardener-robot added the merge/squash Should be merged via 'Squash and merge' label May 19, 2021
@BeckerMax
Copy link
Contributor Author

/ready-for-review

@gardener-robot gardener-robot marked this pull request as ready for review May 19, 2021 07:19
rfranzke
rfranzke approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 19, 2021
@BeckerMax
Copy link
Contributor Author

I guess we wait before cutting a new version of the os-extension provider until we released a new version of g/g ? So the go.mod points to a proper version and not a commit?

@BeckerMax BeckerMax requested a review from vpnachev May 19, 2021 07:21
vpnachev
vpnachev approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I guess we wait before cutting a new version of the os-extension provider until we released a new version of g/g ? So the go.mod points to a proper version and not a commit?

I do not see a problem when a commit is used.

@rfranzke
Copy link
Member

There is no problem, but we agreed to use only released tags when an extension is released.
/cc @ialidzhikov

@rfranzke
Copy link
Member

@BeckerMax Please open similar PRs for the other OS extensions.

@rfranzke rfranzke merged commit a5dd5e2 into gardener:master May 21, 2021
@ialidzhikov ialidzhikov mentioned this pull request May 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/security Security related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) os/garden-linux Related to Garden Linux OS reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@BeckerMax @rfranzke @vpnachev @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot