Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the DHCP client aware of MTU changes #11

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Make the DHCP client aware of MTU changes #11

merged 1 commit into from
Mar 27, 2020

Conversation

vpnachev
Copy link
Member

What this PR does / why we need it:
Make the DHCP client aware of MTU changes

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The dhcp client `wicked` is now aware of the MTU customization and it will not revert the MTU settings.

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 26, 2020
@zanetworker
Copy link

/lgtm lets wait for tomorrow as discussed to see if the MTU persists.

@ghost ghost added the reviewed/lgtm Has approval for merging label Mar 26, 2020
@vpnachev
Copy link
Member Author

After 15 hours the MTU has not been changed

$ uptime ; ip a s eth0
 07:49:46  up  15:18,  0 users,  load average: 0.10, 0.34, 0.47
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1460 qdisc mq state UP group default qlen 1000

@vpnachev vpnachev marked this pull request as ready for review March 27, 2020 07:51
@vpnachev vpnachev requested review from a team as code owners March 27, 2020 07:51
rfranzke
rfranzke approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zanetworker
Copy link

zanetworker commented Mar 27, 2020 •
edited
Loading

@vpnachev I just noticed that the test cluster is only one-node, in that case route advertisement is not taken into consideration, would have been nice if it was multi-node, but I guess it wouldn't matter since I had already tried disabling route-advertisment all together and it still flipped.

@vpnachev
Copy link
Member Author

/hold

Scaling up the test cluster to 2 nodes. Will come back with result by end of the day.

@vpnachev
Copy link
Member Author

/hold-cancel

After 9+ hours both nodes have not reset their MTU.

@vpnachev vpnachev merged commit 7a50503 into gardener:master Mar 27, 2020
@vpnachev vpnachev deleted the mtu/fix-dhcp-reset branch March 27, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@zanetworker zanetworker Awaiting requested review from zanetworker

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vpnachev @zanetworker @rfranzke @gardener-robot-ci-2