Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛡 Revendor gardener/gardener@v1.39, update Golang version to 1.17, enable ServiceAccount token projection #60

Merged
merged 2 commits into from
Jan 26, 2022
Merged

🛡 Revendor gardener/gardener@v1.39, update Golang version to 1.17, enable ServiceAccount token projection #60

merged 2 commits into from
Jan 26, 2022

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Dec 17, 2021 •
edited

How to categorize this PR?

/area security
/kind enhancement
/os suse-chost
/merge squash

What this PR does / why we need it:

  • Revendor gardener/gardener@v1.39.
  • Update Golang version to 1.17.
  • When the extension is running on a seed with a gardenlet of at least v1.37 then ServiceAccount token projection is enabled.

ℹ️ The branch.cfg definition is still using Golang 1.16, hence, the verify step may fail. Once this PR is approved, we can adapt the branch.cfg (also update to 1.17) and then re-trigger the CI pipeline for this PR.

Which issue(s) this PR fixes:
Part of gardener/gardener#4659
Part of gardener/gardener#4878

Special notes for your reviewer:
✅ Depends on gardener/gardener#5162 and v1.39 release, hence, PR is in draft state.

Release note:

The Golang version has been updated to `1.17.5`.

The extension controller uses a projected `ServiceAccount` token in case it runs on a seed with a gardenlet of at least `v1.37` or higher.

@gardener-robot gardener-robot added area/security Security related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' os/suse-chost Related to SUSE Container Host OS needs/review Needs review labels Dec 17, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2021
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Dec 17, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 17, 2021
@vpnachev vpnachev mentioned this pull request Jan 18, 2022
Merged
@rfranzke rfranzke mentioned this pull request Jan 24, 2022
Closed
27 tasks
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Jan 25, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 25, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 25, 2022
@gardener gardener deleted a comment from gardener-robot Jan 25, 2022
@rfranzke
Copy link
Member Author

/ready
/invite @BeckerMax @timebertt
/invite @vpnachev

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 25, 2022
@gardener-robot gardener-robot marked this pull request as ready for review January 25, 2022 08:12
@gardener-robot gardener-robot requested review from a team as code owners January 25, 2022 08:12
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 25, 2022
vpnachev
vpnachev approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I'm updating pipeline definition to use golang 1.17.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Jan 25, 2022
@rfranzke
Copy link
Member Author

Great, thanks for your help!

@vpnachev
Copy link
Member

/ok-to-test

@gardener-robot gardener-robot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 25, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 25, 2022
@rfranzke rfranzke merged commit ad826f6 into gardener:master Jan 26, 2022
@rfranzke rfranzke deleted the enh/tr branch January 26, 2022 16:35
@rfranzke rfranzke mentioned this pull request Apr 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@BeckerMax BeckerMax Awaiting requested review from BeckerMax

@timebertt timebertt Awaiting requested review from timebertt

Assignees
No one assigned
Labels
area/security Security related kind/enhancement Enhancement, improvement, extension merge/squash Should be merged via 'Squash and merge' needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) os/suse-chost Related to SUSE Container Host OS reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rfranzke @vpnachev @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot