Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TransmitUnencoded flag #42

Merged
merged 1 commit into from Jun 10, 2021
Merged

Support TransmitUnencoded flag #42

merged 1 commit into from Jun 10, 2021

Conversation

BeckerMax
Copy link
Contributor

Accepts the flag Transmit Unencoded.

Needed for creation of bootstrap-tokens for machines introduced here: gardener/gardener#3902

How to categorize this PR?
/area security
/kind enhancement
/os ubuntu

What this PR does / why we need it:
See gardener/gardener#3898 and gardener/gardener#3902

Release note:

Introduces new flag `TransmitUnencoded` which writes file content unencoded into the worker resource.

Support TransmitUnencoded flag
7ae723f 
Needed for creation of bootstrap-tokens for machines introduced here: gardener/gardener#3902
@BeckerMax BeckerMax requested review from a team as code owners June 10, 2021 09:32
@gardener-robot gardener-robot added area/security Security related kind/enhancement Enhancement, improvement, extension os/ubuntu Related to Ubuntu OS needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 10, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 10, 2021
vpnachev
vpnachev approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 10, 2021
@vpnachev vpnachev merged commit 91ff65c into gardener:master Jun 10, 2021
@BeckerMax BeckerMax deleted the enh/transmit-unencoded branch June 10, 2021 10:35
@BeckerMax BeckerMax mentioned this pull request Jun 21, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

Assignees
No one assigned
Labels
area/security Security related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) os/ubuntu Related to Ubuntu OS reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BeckerMax @vpnachev @gardener-robot-ci-2 @gardener-robot