Support for Kubernetes v1.23 #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/open-source
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
This was referenced Jan 26, 2022
|
/ready |
rfranzke
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
/invite @jia-jerry @EmoinLanyu |
|
@EmoinLanyu, @jia-jerry You have pull request review open invite, please check |
rfranzke
force-pushed
the
kubernetes-v1.23
branch
from
07527c8
to
425b97e
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-hcnwb +---------------------+---------------------+--------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+--------+----------+ | infrastructure-test | infrastructure-test | Failed | 4m8s | +---------------------+---------------------+--------+----------+ |
|
@rfranzke You need rebase this pull request with latest master branch. Please check. |
rfranzke
force-pushed
the
kubernetes-v1.23
branch
from
425b97e
to
bf35e1f
Compare
|
@EmoinLanyu Rebased |
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
jia-jerry
reviewed
Feb 10, 2022
| @@ -125,27 +127,35 @@ func (e *ensurer) EnsureKubeletServiceUnitOptions(ctx context.Context, gctx gcon | |||
| return new, nil | |||
| } | |||
|
|
|||
| func ensureKubeletCommandLineArgs(command []string) []string { | |||
| func ensureKubeletCommandLineArgs(command []string, kubeletVersion *semver.Version) []string { | |||
| // TODO: Figure out how to provide the provider-id via the kubelet config file (as of Kubernetes 1.19 the kubelet config | |||
| // offers a new `providerID` field which can be used, and it's expected that `--provider-id` will be deprecated eventually). | |||
| // Today, the problem is that the provider ID is determined dynamically using the script above, but the kubelet config cannot | |||
| // reference environment variables like it's possible today with the CLI parameters. | |||
| // See https://github.com/kubernetes/kubernetes/pull/90494 | |||
| command = extensionswebhook.EnsureStringWithPrefix(command, "--provider-id=", "${PROVIDER_ID}") | |||
There was a problem hiding this comment.
Do we need to move provider-id to config file too?
There was a problem hiding this comment.
Eventually yes, but not part of this PR. I have talked about this in #202 (comment)
There was a problem hiding this comment.
Do we need to move
provider-idto config file too?
It is now addressed in TODO. For now I think we can keep it this way and figure out a solution later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source usability
/kind enhancement
/platform alicloud
/exp intermediate
/topology garden seed shoot
/merge squash
What this PR does / why we need it:
This PR adds support for Kubernetes 1.23 to the extension.
Which issue(s) this PR fixes:
Part of gardener/gardener#5102
Part of #202
Special notes for your reviewer:
Release note: