Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch remaining images from k8s.gcr.io to registry.k8s.io #616

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Switch remaining images from k8s.gcr.io to registry.k8s.io #616

merged 1 commit into from
Jun 26, 2023

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Jun 16, 2023 •
edited
Loading

How to categorize this PR?

/area quality
/kind bug
/platform alicloud

What this PR does / why we need it:
9487c0b introduced several k8s.gcr.io images.
k8s.gcr.io should not be used anymore - see https://kubernetes.io/blog/2023/03/10/image-registry-redirect/

Which issue(s) this PR fixes:
See above

Special notes for your reviewer:
N/A

Release note:

The following images are updated:
- k8s.gcr.io/sig-storage/csi-provisioner:v3.3.0 -> registry.k8s.io/sig-storage/csi-provisioner:v3.3.0
- k8s.gcr.io/sig-storage/csi-snapshotter:v6.1.0 -> registry.k8s.io/sig-storage/csi-snapshotter:v6.1.0
- k8s.gcr.io/sig-storage/snapshot-validation-webhook:v6.1.0 -> registry.k8s.io/sig-storage/snapshot-validation-webhook:v6.1.0
- k8s.gcr.io/sig-storage/snapshot-controller:v6.1.0 -> registry.k8s.io/sig-storage/snapshot-controller:v6.1.0

@ialidzhikov ialidzhikov requested review from a team as code owners June 16, 2023 11:37
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug platform/alicloud Alicloud platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jun 16, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 16, 2023
@shaoyongfeng
Copy link
Contributor

Hi @ialidzhikov ,
can you rebase this PR?

@ialidzhikov
Copy link
Member Author

Hi @ialidzhikov , can you rebase this PR?

Done.

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 26, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 26, 2023
@shaoyongfeng shaoyongfeng merged commit 2064b1e into gardener:master Jun 26, 2023
9 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaoyongfeng shaoyongfeng shaoyongfeng approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/alicloud Alicloud platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ialidzhikov @shaoyongfeng @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot