Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mcm to use worker secret ref. for the machine class credentialsSecretRef #230

Merged
merged 2 commits into from
Jan 8, 2021
Merged

update mcm to use worker secret ref. for the machine class credentialsSecretRef #230

merged 2 commits into from
Jan 8, 2021

Conversation

danielfoehrKn
Copy link
Contributor

How to categorize this PR?

/area quality
/kind enhancement
/priority normal
/platform azure

What this PR does / why we need it:
Uses the machine classes .{spec.}credentialsSecretRef field. It is a reference to a secret containing only the credentials, while today's .{spec.}secretRef still contains the user-data. See here for more details.

Uses the worker's secret reference as the credentialsSecretRef.
This means all worker pools use the same "cloudprovider" secret containing only the cloud provider credentials.
The existing MachineClass SecretReference then only contains the user data that is different for each pool.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Reducing credential update complexity by all the machine classes using the new .{spec.}credentialsSecretRef field.
This means all worker pools use the same "cloudprovider" secret containing only the cloud provider credentials.
The existing MachineClass SecretReference only contains the user data that is different for each pool.

@danielfoehrKn danielfoehrKn requested review from a team as code owners December 16, 2020 14:11
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure priority/normal needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Dec 16, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 16, 2020
@danielfoehrKn danielfoehrKn force-pushed the quality/machine-class-credentials branch from 2c1f0ec to 6cc0aa2 Compare December 16, 2020 15:17
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2020
@danielfoehrKn danielfoehrKn force-pushed the quality/machine-class-credentials branch from 6cc0aa2 to f678e66 Compare December 16, 2020 15:35
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2020
@ialidzhikov
Copy link
Member

/status author-action

@gardener-robot gardener-robot added the status/author-action Issue requires issue author action label Dec 16, 2020
@gardener-robot
Copy link

@danielfoehrKn The pull request was assigned to you under author-action. Please unassign yourself when you are done. Thank you.

@danielfoehrKn danielfoehrKn force-pushed the quality/machine-class-credentials branch from f678e66 to 9675adc Compare December 16, 2020 15:50
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2020
@danielfoehrKn danielfoehrKn force-pushed the quality/machine-class-credentials branch from 9675adc to 22d7fa4 Compare December 16, 2020 16:01
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2020
@danielfoehrKn danielfoehrKn force-pushed the quality/machine-class-credentials branch from 22d7fa4 to 58a6d1f Compare December 16, 2020 16:01
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2020
@danielfoehrKn danielfoehrKn force-pushed the quality/machine-class-credentials branch from 58a6d1f to f5d67e3 Compare December 16, 2020 16:03
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2020
dkistner
dkistner previously approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Nice PR.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review status/author-action Issue requires issue author action labels Dec 17, 2020
@rfranzke
Copy link
Member

/rebase

@gardener-robot gardener-robot added needs/rebase Needs git rebase and removed reviewed/lgtm Has approval for merging labels Dec 28, 2020
@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label Jan 5, 2021
@danielfoehrKn danielfoehrKn force-pushed the quality/machine-class-credentials branch from f5d67e3 to 3025486 Compare January 8, 2021 08:13
@gardener-robot gardener-robot added the needs/review Needs review label Jan 8, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 8, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 8, 2021
@rfranzke
Copy link
Member

rfranzke commented Jan 8, 2021

@danielfoehrKn can you run make revendor?

rfranzke
rfranzke reviewed Jan 8, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/invite @prashanth26
/assign @prashanth26

@danielfoehrKn danielfoehrKn force-pushed the quality/machine-class-credentials branch from 3025486 to 80ab3f7 Compare January 8, 2021 09:25
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 8, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 8, 2021
prashanth26
prashanth26 approved these changes Jan 8, 2021
View reviewed changes
Copy link

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 8, 2021
rfranzke
rfranzke approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rfranzke rfranzke merged commit b641aa6 into gardener:master Jan 8, 2021
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

@prashanth26 prashanth26 prashanth26 approved these changes

@dkistner dkistner dkistner left review comments

Assignees

@danielfoehrKn danielfoehrKn

@prashanth26 prashanth26

Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@danielfoehrKn @ialidzhikov @gardener-robot @rfranzke @dkistner @prashanth26 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3