Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Kubernetes v1.21 + CSI migration #280

Merged
merged 5 commits into from Apr 19, 2021
Merged

Support for Kubernetes v1.21 + CSI migration #280

merged 5 commits into from Apr 19, 2021

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Apr 9, 2021 •
edited

How to categorize this PR?

/area open-source usability
/kind enhancement
/priority 3
/platform azure
/exp intermediate
/topology garden seed shoot

What this PR does / why we need it:
This PR adds support for 1.21 to the extension and also support for CSI (+ migration for existing clusters).
CSI will be used for 1.21 shoots. Older shoots will keep using the in-tree legacy volume provisioners.

Which issue(s) this PR fixes:
Part of gardener/gardener#3851
Fixes #3

Special notes for your reviewer:

  • ✅ Depends on Support for Kubernetes v1.21 gardener#3860
  • I have successfully validated the functionality as follows:
    • ✅ Create new clusters with versions < 1.21
    • ✅ Create new clusters with version = 1.21
    • ✅ Upgrade old clusters from version 1.20 to version 1.21
    • ✅ Delete clusters with versions < 1.21
    • ✅ Delete clusters with version = 1.21

Release note:

The Azure extension does now support shoot clusters with Kubernetes version 1.21. You should consider the [Kubernetes release notes](https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.21.md) before upgrading to 1.21. Please note that both the Azure Disk CSI driver and Azure File CSI driver will be used for 1.21 shoots. They are compatible with the legacy volume provisioners, however, you might want to update your storage classes and volume handling accordingly. Please find more information about CSI in the official Kubernetes documentation.

@gardener-robot gardener-robot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure priority/3 Priority (lower number equals higher priority) topology/garden Affects Garden clusters topology/seed Affects Seed clusters topology/shoot Affects Shoot clusters needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Apr 9, 2021
@rfranzke rfranzke changed the title Support for Kubernetes v1.21 Support for Kubernetes v1.21 + CSI migration Apr 9, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 9, 2021
@rfranzke rfranzke added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 13, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 13, 2021
@rfranzke
Revendor gardener/gardener to support 1.21 K8s client creation
1c8fca0
@rfranzke
Add Kubernetes 1.21 support to README.md
19a9e30
@rfranzke
Upgrade github.com/gardener/cloud-provider-azure
23a9f75 
```feature dependency github.com/gardener/cloud-provider-azure $70f2ce3b7cdb3fd179cf54d75cd56b009bc5a944
`k8s.io/legacy-cloud-providers` is now updated to `v0.21.0`.
```

```improvement developer github.com/gardener/cloud-provider-azure $32407b45476c7f0473f28d4ea01c7007f85eb089
The alpine version has been updated to `v3.13.4`.
```

```improvement developer github.com/gardener/cloud-provider-azure $32407b45476c7f0473f28d4ea01c7007f85eb089
The Golang version has been updated to `v1.16.3`.
```
@rfranzke
Use InTreePluginAzure{Disk,File}Unregister instead of CSIMigrationAzu…
a9a9651 
…re{Disk,File}Complete

See for more details: kubernetes/kubernetes#98243
@rfranzke
Update CSI-related images to their latest releases
c6d6633
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 14, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 14, 2021
@rfranzke
Copy link
Member Author

/ready

@gardener-robot gardener-robot marked this pull request as ready for review April 14, 2021 08:26
@gardener-robot gardener-robot requested review from a team as code owners April 14, 2021 08:26
@dkistner
Copy link
Member

/assign

dkistner
dkistner approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I played around with it. I can confirm cluster creation/deletion + upgrade does work well.
Also the CSI migration work nicely.

@gardener-robot gardener-robot added needs/lgtm Needs approval for merging reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/lgtm Needs approval for merging labels Apr 15, 2021
@dkistner dkistner removed their assignment Apr 16, 2021
@rfranzke
Copy link
Member Author

Should we merge then?

@dkistner dkistner merged commit 7b64a00 into master Apr 19, 2021
@dkistner dkistner deleted the kubernetes-v1.21 branch April 19, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related exp/intermediate Issue that requires some project experience kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure priority/3 Priority (lower number equals higher priority) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) topology/garden Affects Garden clusters topology/seed Affects Seed clusters topology/shoot Affects Shoot clusters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt CSI for Azure extension beginning with Kubernetes 1.21
5 participants
@rfranzke @dkistner @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot