Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the "garden.sapcloud.io/role" label from control plane components #420

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Remove the "garden.sapcloud.io/role" label from control plane components #420

merged 1 commit into from
Dec 22, 2021

Conversation

ialidzhikov
Copy link
Member

/kind cleanup
/platform azure

Similar to gardener/gardener-extension-provider-aws#422

Ref gardener/gardener#1649

Release note:

NONE

@ialidzhikov
Remove the "garden.sapcloud.io/role" label from control plane components
2a22f76 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested review from a team as code owners December 21, 2021 16:55
@gardener-robot gardener-robot added kind/cleanup Something that is not needed anymore and can be cleaned up platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 21, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 21, 2021
dkistner
dkistner approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 22, 2021
@dkistner dkistner merged commit 1fbb379 into gardener:master Dec 22, 2021
@ialidzhikov ialidzhikov deleted the cleanup/controlplane-pods-deprecated-label branch March 17, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ialidzhikov @dkistner @rfranzke @gardener-robot-ci-2 @gardener-robot