Fix bastion for multi subnet #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kon-angelo Labels area/todo, kind/todo do not exist. |
gardener-robot
added
needs/review
gardener-robot-ci-3
added
the
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-2kzl2 +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 28m42s | | bastion-test | bastion-test | Succeeded | 9m51s | +---------------------+---------------------+-----------+----------+ |
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot
added
area/control-plane
|
@kon-angelo Should we process this PR? |
dkistner
reviewed
Jun 21, 2022
| @@ -62,7 +70,15 @@ func (a *actuator) Reconcile(ctx context.Context, bastion *extensionsv1alpha1.Ba | |||
| return err | |||
| } | |||
|
|
|||
| nic, err := ensureNic(ctx, factory, opt, publicIP) | |||
| if infrastructureStatus.Networks.Layout != "SingleSubnet" { | |||
| return fmt.Errorf("unsupported network layout %s", infrastructureStatus.Networks.Layout) | |||
There was a problem hiding this comment.
Why is the singleSubnet layout not supported?
There was a problem hiding this comment.
I guess forget cherry-pick 042d16b @kon-angelo
There was a problem hiding this comment.
Yes indeed I did. I will push an update
gardener-robot-ci-1
added
reviewed/ok-to-test
|
/cla |
|
@kon-angelo I reached out successfully to the cla-assistant to recheck this pull request. |
gardener-robot
added
reviewed/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/platform azure
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: