Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.37] Keep setting deprecated labels on the nodes #718

Merged
merged 2 commits into from
Aug 8, 2023
Merged

[release-v1.37] Keep setting deprecated labels on the nodes #718

merged 2 commits into from
Aug 8, 2023

Conversation

kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Aug 8, 2023 •
edited by ialidzhikov

How to categorize this PR?

/area control-plane
/kind bug
/platform azure

What this PR does / why we need it:
Cherry pick of #716 and #717

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The node-controller-manager is now set to keep setting deprecated node labels for k8s clusters of version `>=1.26.0, <1.28.0` to ensure pods using persistent volumes with node affinities are scheduled in the cluster.

vpnachev and others added 2 commits August 8, 2023 11:22
@vpnachev @kon-angelo
Configure CCM to keep setting deprecated labes on the nodes (gardener…
fcf5bbc 
…#716)
@ialidzhikov @kon-angelo
Pass the --enable-deprecated-beta-topology-labels flag to cloud-nod…
4a39160 
…e-manager, not cloud-controller-manager (gardener#717)

gardener#716 added the flag to cloud-controller-manager. This fails with:
```
Error: unknown flag: --deprecated-apply-beta-topology-labels
```

The flag is supported for cloud-node-manager. See kubernetes-sigs/cloud-provider-azure#3685.
@kon-angelo kon-angelo requested review from a team as code owners August 8, 2023 09:25
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 8, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 8, 2023
@ialidzhikov ialidzhikov changed the title [release-v1.37] keep setting deprecated labels on the nodes [release-v1.37] Keep setting deprecated labels on the nodes Aug 8, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 8, 2023
ialidzhikov
ialidzhikov approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 8, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 8, 2023
@ialidzhikov ialidzhikov merged commit 5238f11 into gardener:release-v1.37 Aug 8, 2023
18 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 8, 2023
@kon-angelo kon-angelo deleted the hotfix/beta-labels branch August 8, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kon-angelo @ialidzhikov @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot @vpnachev