Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm failing preStop hook #912

Merged
merged 1 commit into from
Jul 11, 2024
Merged

rm failing preStop hook #912

merged 1 commit into from
Jul 11, 2024

Conversation

AndreasBurger
Copy link
Member

@AndreasBurger AndreasBurger commented Jul 4, 2024 •
edited
Loading

How to categorize this PR?
/area storage
/kind bug
/platform azure

What this PR does / why we need it:
This PR removes the failing preStop lifecycle hook from the node-driver-registrar container in csi-driver-node daemonset.yaml. The distroless registrar image lacks /bin/sh, causing the hook to fail. Socket removal is now handled internally by the registrar, eliminating the need for the hook (see kubernetes-csi/node-driver-registrar#61).

Special notes for your reviewer:
This is gardener/gardener-extension-provider-gcp#792 for Azure

Release note:

Removed unnecessary preStop hook from `node-driver-registrar` in `csi-driver-node`, as socket removal is now handled internally by `node-driver-registrar`, resolving distroless image error.

@AndreasBurger AndreasBurger requested review from a team as code owners July 4, 2024 11:50
@gardener-robot gardener-robot added area/storage Storage related kind/bug Bug platform/azure Microsoft Azure platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 4, 2024
hebelsan
hebelsan approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 5, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 5, 2024
@kon-angelo kon-angelo merged commit a6a8ac2 into gardener:master Jul 11, 2024
18 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hebelsan hebelsan hebelsan approved these changes

Assignees
No one assigned
Labels
area/storage Storage related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/azure Microsoft Azure platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@AndreasBurger @hebelsan @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot @kon-angelo