update mcm and use worker secret ref. for the machine class credentialsSecretRef #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/quality
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
|
/rebase |
gardener-robot
added
needs/rebase
danielfoehrKn
force-pushed
the
quality/machine-class-credentials
branch
from
2a3f61f
to
e1814d9
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
rfranzke
approved these changes
Jan 8, 2021
prashanth26
reviewed
Jan 8, 2021
There was a problem hiding this comment.
As the master is using the MCM-provider-gcp with the required changes here - https://github.com/gardener/gardener-extension-provider-gcp/blob/master/charts/images.yaml#L38 & gardener/machine-controller-manager-provider-gcp@5783306.
/lgtm
prashanth26
approved these changes
Jan 8, 2021
gardener-robot
added
priority/3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality
/kind enhancement
/priority normal
/platform gcp
What this PR does / why we need it:
Uses the machine classes .{spec.}credentialsSecretRef field. It is a reference to a secret containing only the credentials, while today's .{spec.}secretRef still contains the user-data. See here for more details.
Uses the worker's secret reference as the credentialsSecretRef.
This means all worker pools use the same "cloudprovider" secret containing only the cloud provider credentials.
The existing MachineClass SecretReference then only contains the user data that is different for each pool.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: