Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nil pointer when applying machine class chart #45

Merged
merged 1 commit into from
Mar 11, 2020
Merged

fix nil pointer when applying machine class chart #45

merged 1 commit into from
Mar 11, 2020

Conversation

mvladev
Copy link

@mvladev mvladev commented Mar 11, 2020

What this PR does / why we need it:

fix nil pointer when applying machine class chart

Which issue(s) this PR fixes:
Related gardener/gardener#2037

Special notes for your reviewer:

Release note:

Fix nil pointer when applying machine class chart

@mvladev mvladev requested review from a team as code owners March 11, 2020 14:20
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 11, 2020
@ialidzhikov
Copy link
Member

ialidzhikov commented Mar 11, 2020 •
edited

Nice catch, thank you! I hit just the same with the aws provider.
There is a test failure. Could you please check it? https://concourse.ci.gardener.cloud/builds/197551

@mvladev mvladev force-pushed the fix-nil-pointer-chart-options branch from 1acd102 to 552ec1d Compare March 11, 2020 15:48
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2020
@mvladev
Copy link
Author

mvladev commented Mar 11, 2020

fixed the broken test

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 11, 2020
ialidzhikov
ialidzhikov approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ialidzhikov ialidzhikov merged commit 900b647 into gardener:master Mar 11, 2020
@mvladev mvladev deleted the fix-nil-pointer-chart-options branch March 11, 2020 16:24
@majst01 majst01 mentioned this pull request Mar 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mvladev @ialidzhikov @gardener-robot-ci-1 @gardener-robot-ci-3