Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.14] get missing auth_aul from cloudprofile #196

Merged
merged 1 commit into from
Dec 18, 2020
Merged

[release-v1.14] get missing auth_aul from cloudprofile #196

merged 1 commit into from
Dec 18, 2020

Conversation

kon-angelo
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind bug
/priority normal
/platform openstack

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix a bug, where a missing "auth_url" field from the credentials secret would block the creation of a shoot. In case this field is now missing from the provided credentials, the auth_url is taken from the `CloudProfile` used instead.

@kon-angelo kon-angelo requested review from a team as code owners December 18, 2020 11:54
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/bug Bug platform/openstack OpenStack platform/infrastructure priority/normal size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 18, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 18, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 18, 2020
@dkistner
Copy link
Member

Cherry-pick of #195

dkistner
dkistner approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 18, 2020
@dkistner dkistner changed the title get missing auth_aul from cloudprofile [release-v1.14] get missing auth_aul from cloudprofile Dec 18, 2020
@dkistner dkistner merged commit cc90e24 into gardener:release-v1.14 Dec 18, 2020
@kon-angelo kon-angelo deleted the fix-missing-auth-url-hotfix branch January 26, 2021 11:34
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kon-angelo @dkistner @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot