-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update machineclasses to use cloudprovider secret #207
update machineclasses to use cloudprovider secret #207
Conversation
@kon-angelo Labels area/todo, kind/todo do not exist. |
81aee8f
to
6f73b34
Compare
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@kon-angelo - The PR looks good from my side. You can open it for review from other colleagues.
needs/rebase
6f73b34
to
fca1289
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it :)
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks.
How to categorize this PR?
/area control-plane
/kind enhancement
/priority normal
/platform openstack
What this PR does / why we need it:
Uses the machine classes .{spec.}credentialsSecretRef field. It is a reference to a secret containing only the credentials, while today's
.spec.secretRef
still contains the user-data. See here for more details.Uses the worker's secret reference as the credentialsSecretRef.
This means all worker pools use the same "cloudprovider" secret containing only the cloud provider credentials.
The existing MachineClass SecretReference then only contains the user data that is different for each pool.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Set to draft, due to the pending discussion in gardener/gardener-extension-provider-aws#238.
Release note: