Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret data checksum for CSI driver on worker nodes #226

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Secret data checksum for CSI driver on worker nodes #226

merged 1 commit into from
Feb 12, 2021

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area usability
/kind bug
/priority normal
/platform openstack

What this PR does / why we need it:
When the cloud-provider-config for the CSI disk plugin changes then it needs to be restarted so that it can reload the changed config. This PR adds the missing checksum annotation to trigger the restart on config change.

Special notes for your reviewer:
/cc @vlerenc

Release note:

An issue has been resolved which prevented the CSI driver from properly functioning when the infrastructure credentials were changed.

@rfranzke rfranzke requested review from a team as code owners February 12, 2021 13:33
@gardener-robot gardener-robot added area/usability Usability related kind/bug Bug platform/openstack OpenStack platform/infrastructure priority/normal needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 12, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 12, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 12, 2021
vpnachev
vpnachev approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 12, 2021
ialidzhikov
ialidzhikov approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vpnachev vpnachev merged commit 266419b into gardener:master Feb 12, 2021
@rfranzke rfranzke deleted the fix/csi-checksum branch February 15, 2021 07:14
@ialidzhikov ialidzhikov mentioned this pull request Feb 17, 2021
Merged
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpnachev vpnachev vpnachev approved these changes

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
area/usability Usability related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rfranzke @vpnachev @ialidzhikov @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot