Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating Subnet Config: Wildcards and Defaults #237

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Floating Subnet Config: Wildcards and Defaults #237

merged 2 commits into from
Mar 9, 2021

Conversation

dkistner
Copy link
Member

@dkistner dkistner commented Mar 1, 2021 •
edited

How to categorize this PR?

/kind enhancement
/priority normal
/platform openstack

What this PR does / why we need it:
Allow to configure a default subnet for floating pool configurations in the CloudProfile.
This will be used to assign the router interface of a Shoot cluster (if not an existing router is used) to the matching subnet.
Furthermore enable the selection of floating pool subnets by wildcards.

In addition it is now forbidden to change the floating pool or the floating pool subnet configuration as this is not supported by Neutron.

This change require a Terraformer with openstack provider v1.37 or higher.
The floating subnet id field is removed from the Infrastructure state as it was unused.

Which issue(s) this PR fixes:
Fixes #219

Special notes for your reviewer:

Release note:

Allow to configure a default subnet for floating pools configuration in the CloudProfile and enable the selection of floating pool subnet via a name pattern.
The selection of the subnet in floating pool network via `InfrastructureConfig.floatingPoolSubnetName` can now be also done via a name pattern matching.

/invite @kon-angelo @MartinWeindel

cc @RaphaelVogel @kayrus

@dkistner
Forbid changing the floating network/subnet
e04bb9f 
Make the floating network and floating subnet fields immuatble.
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else labels Mar 1, 2021
@gardener-robot gardener-robot added kind/enhancement Enhancement, improvement, extension needs/review Needs review platform/openstack OpenStack platform/infrastructure priority/normal size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Mar 1, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 1, 2021
@dkistner dkistner marked this pull request as ready for review March 2, 2021 15:26
@dkistner dkistner requested review from a team as code owners March 2, 2021 15:26
MartinWeindel
MartinWeindel requested changes Mar 2, 2021
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I only found some minor typos.

pkg/apis/openstack/helper/helper.go Outdated Show resolved Hide resolved
pkg/apis/openstack/helper/helper.go Outdated Show resolved Hide resolved
pkg/apis/openstack/types_infrastructure.go Outdated Show resolved Hide resolved
pkg/apis/openstack/v1alpha1/types_infrastructure.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Mar 2, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 3, 2021
@dkistner
Copy link
Member Author

dkistner commented Mar 3, 2021

Thanks @MartinWeindel done :)

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 3, 2021
MartinWeindel
MartinWeindel previously approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Mar 3, 2021
@gardener-robot gardener-robot added needs/review Needs review and removed reviewed/lgtm Has approval for merging labels Mar 3, 2021
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/normal labels Mar 8, 2021
@gardener-robot gardener-robot removed the priority/3 Priority (lower number equals higher priority) label Mar 8, 2021
@dkistner
Floating Subnet Config: Wildcards and Defaults
ebfbf07 
Allow to configure a default subnet for floating pools configuration in the CloudProfile.
This will be used to assign the router (if not an existing one passed) to the matching subnet.
Furthermore enable the selection of floating subnet by wildcards

This change require a Terraformer with openstack provider v1.37 or higher.
The floating subnet id is removed from the Infrastrucutre state as it was not used.
@gardener-robot gardener-robot added needs/changes Needs (more) changes needs/second-opinion Needs second review by someone else labels Mar 9, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 9, 2021
@kon-angelo kon-angelo merged commit 46614d0 into master Mar 9, 2021
@dkistner dkistner deleted the fip-default-subnet branch March 9, 2021 14:58
@gardener gardener deleted a comment from gardener-robot Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

@MartinWeindel MartinWeindel Awaiting requested review from MartinWeindel

Assignees
No one assigned
Labels
kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else platform/openstack OpenStack platform/infrastructure size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an ability to specify a subnet pattern for a router static IP
6 participants
@dkistner @MartinWeindel @kon-angelo @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot