Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix failing servergroup creation on Nova 2.64+ #245

Merged
merged 1 commit into from
Mar 24, 2021
Merged

fix failing servergroup creation on Nova 2.64+ #245

merged 1 commit into from
Mar 24, 2021

Conversation

kon-angelo
Copy link
Contributor

@kon-angelo kon-angelo commented Mar 24, 2021 •
edited

How to categorize this PR?

/area control-plane
/kind bug
/priority blocker
/platform openstack

What this PR does / why we need it:
This PR fixes an issue when to trying to create servergroups with nova API >= 2.64. The request no longer accepts the Policies field on those versions. The current client picked the highest supported version of the Nova API and if that was greater than 2.64 the creation of servergroups would fail.

Instead, do not set the microversion of the client. In case soft-* servergroup policies are requested, pin the client to 2.15, since its the minimum version that supports these values.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix a bug in servergroup creation when the Nova API is `> 2.63`

@kon-angelo kon-angelo requested review from a team as code owners March 24, 2021 14:53
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug platform/openstack OpenStack platform/infrastructure priority/blocker Needs to be resolved now, because it breaks the service needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 24, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 24, 2021
@kon-angelo kon-angelo changed the title fix fix failing servergroup creation on Nova 2.64+ Mar 24, 2021
dkistner
dkistner approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 24, 2021
@kon-angelo kon-angelo merged commit 6b94e08 into gardener:master Mar 24, 2021
@kon-angelo kon-angelo deleted the servergroup-hotfix branch April 28, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure priority/blocker Needs to be resolved now, because it breaks the service reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kon-angelo @dkistner @gardener-robot-ci-2 @gardener-robot