-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deserialize custom resources with EnableStrict #253
Conversation
835c315
to
a8a7830
Compare
a8a7830
to
aabb46e
Compare
@dkistner @kon-angelo should we hold this PR? Are you validating a release? |
/hold @rfranzke Yes we are validating a release. We can merge this in the coming days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The TestDefinitions need an update as well.
diff --git a/.test-defs/infrastructure-test.yaml b/.test-defs/infrastructure-test.yaml
index 341b20dd..dd7f648c 100644
--- a/.test-defs/infrastructure-test.yaml
+++ b/.test-defs/infrastructure-test.yaml
@@ -19,4 +19,4 @@ spec:
--region="$REGION"
--tenant-name="$TENANT_NAME"
--user-name="$USER_NAME"
- image: eu.gcr.io/gardener-project/3rd/golang:1.15.7
+ image: eu.gcr.io/gardener-project/3rd/golang:1.16.3
diff --git a/.test-defs/provider-openstack.yaml b/.test-defs/provider-openstack.yaml
index d742f7bc..31820e6e 100644
--- a/.test-defs/provider-openstack.yaml
+++ b/.test-defs/provider-openstack.yaml
@@ -16,4 +16,4 @@ spec:
--loadbalancer-provider=$LOADBALANCER_PROVIDER
--network-worker-cidr=$NETWORK_WORKER_CIDR
- image: eu.gcr.io/gardener-project/3rd/golang:1.15.7
+ image: eu.gcr.io/gardener-project/3rd/golang:1.16.3
aabb46e
to
d024d02
Compare
Done |
Can you please revendor the |
d024d02
to
d3a57f8
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @stoyanr, can you check why the |
How to categorize this PR?
/area control-plane
/kind enhancement
/priority 3
/platform openstack
What this PR does / why we need it:
EnableStrict
option to all places where a codec factory is created, to ensure that extension resource configs are always deserialized in "strict" mode. This means that resources with fields that are not allowed by the API schema will be rejected by validation and will cause errors (categorized asERR_CONFIGURATION_PROBLEM
) during reconciliation as well.ControlPlaneConfig
andWorkerConfig
, and errors are correctly categorized.Which issue(s) this PR fixes:
Fixes gardener/gardener-extension-provider-azure#270, see also gardener/gardener-extension-provider-azure#271 and gardener/gardener-extension-provider-gcp#249.
Special notes for your reviewer:
Release note: