-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify container resources for CSI sidecars #259
Specify container resources for CSI sidecars #259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
7342232
to
f55b859
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Nice suggestion, but I don't want to adapt only 1 template file to use this |
/kind enhancement
/platform openstack
Currently the liveness-probe and csi-node-driver-registrar sidecars on the csi-driver-node Pod, the liveness-probe sidecar on the csi-driver-controller Pod do not define resource requests and limits.
Without any resource limits, currently we don't prevent any abnormal usage of resources by these sidecars. For example we recently observed a huge memory leak (see more details in #256) in the liveness-probe sidecar - because of the memory leak the sidecar container was using more than 1Gi when the normal (without the memory leak) memory usage of the container is ~20Mi. With specifying resource requests and limits, we can prevent such cases.
Release note: