Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify container resources for CSI sidecars #259

Merged

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Apr 9, 2021

/kind enhancement
/platform openstack

Currently the liveness-probe and csi-node-driver-registrar sidecars on the csi-driver-node Pod, the liveness-probe sidecar on the csi-driver-controller Pod do not define resource requests and limits.
Without any resource limits, currently we don't prevent any abnormal usage of resources by these sidecars. For example we recently observed a huge memory leak (see more details in #256) in the liveness-probe sidecar - because of the memory leak the sidecar container was using more than 1Gi when the normal (without the memory leak) memory usage of the container is ~20Mi. With specifying resource requests and limits, we can prevent such cases.

Release note:

The few CSI sidecar containers that didn't specify any resource requests and limits do now specify appropriate requests and limits. 

@ialidzhikov ialidzhikov requested review from a team as code owners April 9, 2021 13:21
@gardener-robot gardener-robot added kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Apr 9, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 9, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 9, 2021
vpnachev
vpnachev previously approved these changes Apr 9, 2021
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

dkistner
dkistner previously approved these changes Apr 9, 2021
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov dismissed stale reviews from dkistner and vpnachev via f55b859 April 13, 2021 12:19
@gardener-robot gardener-robot added needs/review Needs review and removed needs/review Needs review labels Apr 13, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 13, 2021
@gardener-robot gardener-robot removed the needs/review Needs review label Apr 13, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 13, 2021
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ialidzhikov
Copy link
Member Author

ialidzhikov commented Apr 15, 2021

completely optional: how about nindent for readability

resources: {{ toYaml .Values.resources.nodeDriverRegistrar | nindent 10 }}

Nice suggestion, but I don't want to adapt only 1 template file to use this nindent approach and to leave all other template files to use the indent approach. I don't want to adapt all templates under chart/ neither as it is out of scope of this PR. For consistency reasons I will leave as it is.

@ialidzhikov ialidzhikov merged commit dde2e83 into gardener:master Apr 15, 2021
@ialidzhikov ialidzhikov deleted the fix/resource-requests-limits branch May 10, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants