Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not print secret content in error message #274

Merged
merged 1 commit into from May 14, 2021
Merged

Do not print secret content in error message #274

merged 1 commit into from May 14, 2021

Conversation

vpnachev
Copy link
Member

How to categorize this PR?

/kind bug
/platform openstack

What this PR does / why we need it:
Do not print secret content in error message

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

No longer print secret data into error messages.

@vpnachev vpnachev requested review from a team as code owners May 14, 2021 13:19
@gardener-robot gardener-robot added kind/bug Bug platform/openstack OpenStack platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 14, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 14, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 14, 2021
mvladev
mvladev approved these changes May 14, 2021
View reviewed changes
Copy link

@mvladev mvladev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 14, 2021
@vlerenc
Copy link
Member

vlerenc commented May 14, 2021

@vpnachev @mvladev Thanks!

@vpnachev vpnachev merged commit 0e6ca32 into gardener:master May 14, 2021
@vpnachev vpnachev deleted the do-not-log-secret-data branch May 14, 2021 13:29
This was referenced May 14, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvladev mvladev mvladev approved these changes

Assignees
No one assigned
Labels
kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vpnachev @vlerenc @mvladev @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot