Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revendor g/g to 1.26 #308

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Conversation

BeckerMax
Copy link

Co-authored-by: Marco Voelz marco.voelz@sap.com

Release note:

Do not trigger a node rollout when switching from `CRI.Name==nil` to `CRI.Name==docker`.

Co-authored-by: Marco Voelz <marco.voelz@sap.com>
@BeckerMax BeckerMax requested review from a team as code owners July 14, 2021 11:35
@BeckerMax
Copy link
Author

/test

@testmachinery
Copy link

testmachinery bot commented Jul 14, 2021

🔥 Oops, something went wrong @BeckerMax
.
Tip: Check whether the test is correctly defined by flags or by the default test config in the repository.

Command test
Runs a testrun that is either specified by command line flags or in the default values.
The specified path is rendered as testrun and the current repository is injected as a default location.


Example: /test [sub-command] [--flags]

Usage:
      --dry-run              Print the rendered testrun
      --set stringArray      sets additional helm values
      --template             run go templating on the configured file before execution
      --testrunPath string   path to the testrun file that should be executed

Instructions for interacting with me using PR comments are available here

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 14, 2021
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else kind/test Test labels Jul 14, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 14, 2021
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold due to ongoing release validation
/assign @dkistner @kon-angelo

@gardener-robot gardener-robot added reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jul 16, 2021
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jul 21, 2021
@dkistner dkistner merged commit f8d87b9 into gardener:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants