Improve LoadBalancerClass validation #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to change the name and purpose of load balancer classes in `.controlPlaneConfig.loadBalancerClasses[]`. The load balancer classes configuration need still to be semantically equal with the load balancer classes from the CloudProfile. Add validation to check if there are no load balancer classes with same name and if there are multiple default or private loadbalancer classes.
gardener-robot
added
kind/api-change
gardener-robot
added
kind/enhancement
gardener-robot-ci-1
added
reviewed/ok-to-test
kon-angelo
reviewed
Jul 16, 2021
gardener-robot-ci-2
added
the
reviewed/ok-to-test
|
/squash |
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
/platform openstack
What this PR does / why we need it:
Allow to change the name and purpose of load balancer classes in
.controlPlaneConfig.loadBalancerClasses[]. The load balancer classes configuration need still to be semantically equal with the load balancer classes from the CloudProfile.Add validation to check if there are no load balancer classes with same name and if there are multiple default or private load balancer classes.
Release note:
/invite @kon-angelo @MartinWeindel
cc @RaphaelVogel