Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add infrastructure ConfigValidator for checking floating pool names #329

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

stoyanr
Copy link
Contributor

@stoyanr stoyanr commented Aug 27, 2021

How to categorize this PR?

/area ops-productivity
/area quality
/kind enhancement
/platform gcp

What this PR does / why we need it:

  • Adds an implementation of the infrastructure.ConfigValidator for checking floating pool names. See Add infrastructure config validator gardener#4547.
  • Adds unit tests for the infrastructure.ConfigValidator implementation.
  • Vendors g/g v1.31.0-dev (in a separate commit).

Which issue(s) this PR fixes:
Fixes #328

Special notes for your reviewer:

Release note:

Floating pool names in infrastructure config are now checked if they exist, and if not the issue is properly reported as `ERR_CONFIGURATION_PROBLEM` with a clear error message.

@stoyanr stoyanr requested review from a team as code owners August 27, 2021 11:07
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 27, 2021
@stoyanr
Copy link
Contributor Author

stoyanr commented Aug 27, 2021

/invite @ialidzhikov @rfranzke @dkistner

@stoyanr
Copy link
Contributor Author

stoyanr commented Aug 27, 2021

/squash
/test

@testmachinery
Copy link

testmachinery bot commented Aug 27, 2021

🔥 Oops, something went wrong @stoyanr
.
Tip: Check whether the test is correctly defined by flags or by the default test config in the repository.

Command test
Runs a testrun that is either specified by command line flags or in the default values.
The specified path is rendered as testrun and the current repository is injected as a default location.


Example: /test [sub-command] [--flags]

Usage:
      --dry-run              Print the rendered testrun
      --set stringArray      sets additional helm values
      --template             run go templating on the configured file before execution
      --testrunPath string   path to the testrun file that should be executed

Instructions for interacting with me using PR comments are available here

@stoyanr
Copy link
Contributor Author

stoyanr commented Aug 27, 2021

/test

@testmachinery
Copy link

testmachinery bot commented Aug 27, 2021

🔥 Oops, something went wrong @stoyanr
.
Tip: Check whether the test is correctly defined by flags or by the default test config in the repository.

Command test
Runs a testrun that is either specified by command line flags or in the default values.
The specified path is rendered as testrun and the current repository is injected as a default location.


Example: /test [sub-command] [--flags]

Usage:
      --dry-run              Print the rendered testrun
      --set stringArray      sets additional helm values
      --template             run go templating on the configured file before execution
      --testrunPath string   path to the testrun file that should be executed

Instructions for interacting with me using PR comments are available here

@stoyanr stoyanr changed the title Add infra config validator Add infrastructure ConfigValidator for checking floating pool names Aug 27, 2021
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Aug 30, 2021
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@stoyanr stoyanr merged commit 323cf3c into gardener:master Aug 30, 2021
@stoyanr stoyanr deleted the add-infra-config-validator branch August 30, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Categorize non-existing floatingPoolName as configuration issue with a better error message
5 participants