Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount host certificate for KCM/CCM #39

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Mar 5, 2020

What this PR does / why we need it:
The OpenStack extension does now by default mount the host certificates from /etc/ssl and /usr/share/ca-certificates into the pods that are running in the seed and need to interact with the OpenStack API (kube-apiserver, kube-controller-manager (only until #1 is fixed), and cloud-controller-manager).
This is to accommodate OpenStack environments that are serving certificates signed by CAs not commonly known/trusted.

Special notes for your reviewer:
/cc @bnerd

Release note:

The OpenStack extension does now by default mount the host certificates from `/etc/ssl` and `/usr/share/ca-certificates` into the pods that are running in the seed and need to interact with the OpenStack API (kube-apiserver, kube-controller-manager (only until #1 is fixed), and cloud-controller-manager).
This is to accommodate OpenStack environments that are serving certificates signed by CAs not commonly known/trusted.

@rfranzke rfranzke requested a review from a team as a code owner March 5, 2020 07:07
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 5, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 5, 2020
@rfranzke rfranzke requested a review from timebertt March 6, 2020 05:44
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 6, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 6, 2020
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm now, thanks

@rfranzke rfranzke merged commit a77303e into gardener:master Mar 6, 2020
@rfranzke rfranzke deleted the fix/certs branch March 6, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants