Support for CSI Manila driver deployment #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
MartinWeindel
force-pushed
the
csi-manila
branch
from
f8633c6
to
7111081
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
MartinWeindel
force-pushed
the
csi-manila
branch
from
7111081
to
b4cad6b
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
|
rebased |
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
MartinWeindel
force-pushed
the
csi-manila
branch
from
b4cad6b
to
8ac8a53
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
MartinWeindel
force-pushed
the
csi-manila
branch
from
8ac8a53
to
948c4b2
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot
added
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
kon-angelo
reviewed
Mar 30, 2023
docs/usage-as-end-user.md
Outdated
| @@ -106,6 +112,9 @@ loadBalancerClasses: | |||
| cloudControllerManager: | |||
| featureGates: | |||
| CustomResourceValidation: true | |||
| #csi | |||
There was a problem hiding this comment.
this needs to be updated right ? And can we also update the example/{infrastructure,controlplane} files ?
There was a problem hiding this comment.
Thanks, missed that.
gardener-robot
added
needs/review
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
This reverts commit 4566a6b.
gardener-robot-ci-2
added
reviewed/ok-to-test
kon-angelo
reviewed
Apr 4, 2023
Comment on lines
103
to
105
| add: ["SYS_ADMIN"] | ||
| allowPrivilegeEscalation: true | ||
| args: |
There was a problem hiding this comment.
The controller does not need the priviledge escalation or sys_admin
kon-angelo
reviewed
Apr 4, 2023
| automountServiceAccountToken: false | ||
| priorityClassName: gardener-system-300 | ||
| containers: | ||
| {{- range .Values.shareProtocols }} |
There was a problem hiding this comment.
I am a bit conflicted. For now we only care about NFS but even if we did have more protocols that we want to support, I am not sure if I would prefer to run them in a "mega"-pod rather than its own separate deployments.
There was a problem hiding this comment.
dropped the range over share protocols
Comment on lines
45
to
47
| capabilities: | ||
| add: ["SYS_ADMIN"] | ||
| allowPrivilegeEscalation: true |
There was a problem hiding this comment.
No hostpath == no need for the extra permissions
| - name: {{ .protocolSelector | lower }}-plugin-dir | ||
| mountPath: /csi | ||
|
|
||
| - name: {{ .protocolSelector | lower }}-nfs-liveness-probe |
There was a problem hiding this comment.
Technically not necessary because manila forwards the requests to NFS ref
charts/internal/shoot-system-components/charts/csi-driver-manila/templates/daemonset-node.yaml
Outdated
Show resolved
Hide resolved
charts/internal/shoot-system-components/charts/csi-driver-manila/templates/daemonset-node.yaml
Outdated
Show resolved
Hide resolved
charts/internal/shoot-system-components/charts/csi-driver-manila/templates/daemonset-node.yaml
Outdated
Show resolved
Hide resolved
...l/seed-controlplane/charts/csi-driver-manila-controller/templates/deployment-controller.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Angelopoulos, Konstantinos <konstantinos.angelopoulos@sap.com>
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/kind enhancement
/platform openstack
What this PR does / why we need it:
Out-of-the-box support for NFS persistent volumes has been added. If enabled, a share network is created and the CSI Manila driver is deployed to the kube-system namespace on the shoot. The following two additional configuration fields are needed to set. In
InfrastructureConfigthe fieldnetworks.shareNetwork.enabledmust be set totrueto create the share network used later. InControlPlaneConfigthe fieldcsi.manila.enabledmust be set totrueto deploy the CSI Manila driver together with the generic CSI NFS driver.Which issue(s) this PR fixes:
Fixes #153
Special notes for your reviewer:
Release note: