Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revendor gardener/gardener after merge of gardener/gardener-extensions #59

Merged
merged 1 commit into from Apr 8, 2020
Merged

Revendor gardener/gardener after merge of gardener/gardener-extensions #59

merged 1 commit into from Apr 8, 2020

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Apr 8, 2020 •
edited

What this PR does / why we need it:
Revendor gardener/gardener after merge of gardener/gardener-extensions

Special notes for your reviewer:
NONE

Release note:

- Add Separate sidecar controller to save worker state under Worker.Status.State
- Add Worker.Status.State restoration functionality 
- Add migration functionality

The `machine.sapcloud.io` CRDs applied by the `./pkg/controller/worker` package do now get a protection label for accidental deletion. See also: https://github.com/gardener/gardener/pull/2066

The OpenStack extension does now support shoot clusters with Kubernetes version 1.18. You should consider the [Kubernetes release notes](https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.18.md) before upgrading to 1.18.

@rfranzke rfranzke requested review from a team as code owners April 8, 2020 04:04
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 8, 2020
timebertt
timebertt approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@MartinWeindel MartinWeindel merged commit 40a4d07 into master Apr 8, 2020
@MartinWeindel MartinWeindel deleted the revendor branch April 8, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timebertt timebertt timebertt approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rfranzke @timebertt @MartinWeindel @gardener-robot-ci-3