Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove blocked-network cidr from kcm #64

Merged
merged 1 commit into from Apr 15, 2020
Merged

remove blocked-network cidr from kcm #64

merged 1 commit into from Apr 15, 2020

Conversation

mvladev
Copy link

@mvladev mvladev commented Apr 15, 2020

What this PR does / why we need it:

Removes access to blocked networks from kube-controller-manager.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`kube-controller-manageer` no longer has access to blocked CIDRs.

@mvladev mvladev requested review from a team as code owners April 15, 2020 16:08
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 15, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 15, 2020
ialidzhikov
ialidzhikov approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ialidzhikov ialidzhikov merged commit 22c5c1e into gardener:master Apr 15, 2020
@mvladev mvladev deleted the kcm-remove-blocked-network branch July 15, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvladev @ialidzhikov @gardener-robot-ci-2