Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm failing preStop hook #802

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AndreasBurger
Copy link
Member

How to categorize this PR?
/area storage
/kind bug
/platform openstack

What this PR does / why we need it:
This PR removes the failing preStop lifecycle hook from the node-driver-registrar container in csi-driver-node daemonset.yaml. The distroless registrar image lacks /bin/sh, causing the hook to fail. Socket removal is now handled internally by the registrar, eliminating the need for the hook (see kubernetes-csi/node-driver-registrar#61).

Special notes for your reviewer:
This is gardener/gardener-extension-provider-gcp#792 for Openstack

Release note:

Removed unnecessary preStop hook from `node-driver-registrar` in `csi-driver-node`, as socket removal is now handled internally by `node-driver-registrar`, resolving distroless image error.

@AndreasBurger AndreasBurger requested review from a team as code owners July 4, 2024 11:38
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2024
@gardener-robot gardener-robot added needs/review Needs review area/storage Storage related kind/bug Bug platform/openstack OpenStack platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage Storage related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/openstack OpenStack platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants