Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region information to cloud-provider config #98

Merged
merged 1 commit into from Jun 17, 2020

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area usability
/kind enhancement
/priority normal
/platform openstack

What this PR does / why we need it:
With this PR we add the region information to the cloud-provider config. This is required to enable the OpenStack cloud controllers to detect the correct Keystone endpoint in case the OpenStack environment has multiple regions.

Special notes for your reviewer:
/cc @timuthy @vasu1124

Release note:

The OpenStack cloud controllers are now correctly bootstrapping and behaving in case the underlying OpenStack environment supports multiple regions.

@rfranzke rfranzke requested review from a team as code owners June 16, 2020 12:47
@gardener-robot gardener-robot added area/usability Usability related kind/enhancement Enhancement, improvement, extension platform/openstack OpenStack platform/infrastructure priority/normal labels Jun 16, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 16, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 16, 2020
@timuthy
Copy link
Contributor

timuthy commented Jun 16, 2020

/assign

Copy link
Contributor

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Jun 16, 2020
@rfranzke rfranzke merged commit 4fc1f15 into gardener:master Jun 17, 2020
@rfranzke rfranzke deleted the feature/cp-cfg-region branch June 17, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/openstack OpenStack platform/infrastructure reviewed/lgtm Has approval for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants