Vendor gardener@1.81.6 and implement ForceDelete
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
do-not-merge/hold
gardener-prow
bot
added
the
size/XXL
acumino
force-pushed
the
vendor/gardener@1.81
branch
from
20077ae
to
bb1a8cc
Compare
acumino
changed the title
gardener@1.81.0-dev and implement ForceDeletegardener@1.81.0 and implement ForceDelete
|
/unhold |
gardener-prow
bot
removed
the
do-not-merge/hold
acumino
force-pushed
the
vendor/gardener@1.81
branch
from
bb1a8cc
to
9cf9534
Compare
acumino
force-pushed
the
vendor/gardener@1.81
branch
2 times, most recently
from
b001823
to
6305e5b
Compare
|
/assign |
ialidzhikov
reviewed
Oct 12, 2023
gardener-prow
bot
added
the
needs-rebase
acumino
force-pushed
the
vendor/gardener@1.81
branch
from
6305e5b
to
8e20896
Compare
gardener-prow
bot
removed
the
needs-rebase
|
/hold for testing |
gardener-prow
bot
added
the
do-not-merge/hold
acumino
force-pushed
the
vendor/gardener@1.81
branch
2 times, most recently
from
1aa2a7f
to
00a7465
Compare
gardener-prow
bot
removed
the
cla: yes
gardener-prow
bot
added
cla: no
|
/unhold |
gardener-prow
bot
removed
the
do-not-merge/hold
ialidzhikov
reviewed
Nov 2, 2023
acumino
force-pushed
the
vendor/gardener@1.81
branch
from
00a7465
to
1470fc8
Compare
|
LGTM label has been added. Git tree hash: 4f41e98416d7438e39f7701af09e84eb6495239b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
ialidzhikov
changed the title
gardener@1.81.0 and implement ForceDeletegardener@1.81.6 and implement ForceDelete
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-registry-cache
that referenced
this pull request
Nov 3, 2023
A leftover from gardener#59
ialidzhikov
added a commit
to ialidzhikov/gardener-extension-registry-cache
that referenced
this pull request
Nov 10, 2023
A leftover from gardener#59
gardener-prow bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
…83) * Do not deploy the `registry-configuration-cleaner` on Shoot deletion If the Shoot is in deletion, then there is no need to clean up the registry configuration from Nodes. The Shoot deletion flows ensures that the Worker is deleted before the Extension deletion. Hence, there are no Nodes, no need to clean up registry configuration. * Nit: Add empty line for better readability A leftover from #59 * Update developer docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area delivery open-source
/kind enhancement
What this PR does / why we need it:
gardener@1.81.0-devForceDeletemethod for extensionWhich issue(s) this PR fixes:
Part of gardener/gardener#3110
Special notes for your reviewer:
/hold
- Need to vendorgardener@1.81when it's released.Release note:
`registry-cache` extension now supports [Shoot Force Deletion](https://github.com/gardener/gardener/blob/v1.82.0/docs/usage/shoot_operations.md#force-deletion).