Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CRDs v1.11 compatible #20

Merged
merged 1 commit into from
May 8, 2020
Merged

Conversation

ialidzhikov
Copy link
Member

What this PR does / why we need it:
See gardener/gardener#1777.

Which issue(s) this PR fixes:
Fixes #18

Special notes for your reviewer:

Release note:

An issue preventing CRDs to be created on v1.11.x cluster is now fixed.

Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov requested review from a team as code owners May 8, 2020 15:57
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 8, 2020
@ialidzhikov
Copy link
Member Author

ialidzhikov commented May 8, 2020

/kind/bug

@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 8, 2020
@ialidzhikov
Copy link
Member Author

/cc @MartinWeindel , can you validate this PR?

@ghost ghost added the kind/bug Bug label May 8, 2020
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@MartinWeindel MartinWeindel merged commit 48807f4 into gardener:master May 8, 2020
@ialidzhikov ialidzhikov deleted the fix/crds branch May 10, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cert-controller-manager is in CrashLoopBackOff for Kubernetes v1.11
4 participants