Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revendor and add issuer secrets to extension status #24

Merged
merged 1 commit into from
May 27, 2020
Merged

Revendor and add issuer secrets to extension status #24

merged 1 commit into from
May 27, 2020

Conversation

stoyanr
Copy link
Contributor

@stoyanr stoyanr commented May 27, 2020

What this PR does / why we need it:

  • Revendor Gardener
  • Implement Migrate and Restore actuator methods
  • Add issuer secrets as resources to extension status so they could be properly migrated

Which issue(s) this PR fixes:
See gardener/gardener#2321

Special notes for your reviewer:

Release note:

Adds issuer secrets as resources to extension status so they could be properly migrated

@stoyanr
Revendor and add issuer secrets to extension status
8997a33 
* Revendor Gardener
* Implement Migrate and Restore actuator methods
* Add issuer secrets as resources to extension status so they could be properly migrated
@stoyanr stoyanr requested review from a team as code owners May 27, 2020 12:56
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 27, 2020
@stoyanr
Copy link
Contributor Author

stoyanr commented May 27, 2020

cc @rfranzke

@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 27, 2020
@stoyanr
Copy link
Contributor Author

stoyanr commented May 27, 2020

cc @timuthy @MartinWeindel

MartinWeindel
MartinWeindel approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ghost ghost added the reviewed/lgtm Has approval for merging label May 27, 2020
@MartinWeindel MartinWeindel merged commit 1aaa4e2 into gardener:master May 27, 2020
@stoyanr stoyanr deleted the private-key-from-secret branch May 28, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stoyanr @MartinWeindel @gardener-robot-ci-2