Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix netpol label for cert-management #27

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Fix netpol label for cert-management #27

merged 1 commit into from
Jun 10, 2020

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Jun 10, 2020

What this PR does / why we need it:
This PR adds the appropriate Gardener netpol label to let the Cert-Management controller talk to public networks.

Release note:

Required network policies for Cert-Management have been aligned with the latest changes from Gardener (https://github.com/gardener/gardener/pull/2339).

@timuthy timuthy added area/networking Networking related priority/critical Needs to be resolved soon, because it impacts users negatively labels Jun 10, 2020
@timuthy timuthy requested review from a team as code owners June 10, 2020 08:40
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 10, 2020
rfranzke
rfranzke approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added the reviewed/lgtm Has approval for merging label Jun 10, 2020
@MartinWeindel MartinWeindel merged commit e8098bd into gardener:master Jun 10, 2020
@timuthy timuthy deleted the fix.netpol branch June 10, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/networking Networking related needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) priority/critical Needs to be resolved soon, because it impacts users negatively reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@timuthy @MartinWeindel @rfranzke @gardener-robot-ci-3 @gardener-robot