Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add object selector for extension type in the gardener-extension-admission-shoot-dns-service webhook #106

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Add object selector for extension type in the gardener-extension-admission-shoot-dns-service webhook #106

merged 1 commit into from
Mar 3, 2022

Conversation

shafeeqes
Copy link
Contributor

How to categorize this PR?

/area robustness
/kind enhancement

What this PR does / why we need it:
This PR adds an object selector for provider type label in the gardener-extension-admission-shoot-dns-service webhook. This helps in filtering out only resources having extension type shoot-dns-service for validation.

Which issue(s) this PR fixes:
Fixes part of gardener/gardener#4932

Special notes for your reviewer:
Related to gardener/gardener#5472

Release note:

The `gardener-extension-admission-shoot-dns-service` webhook now contains an object selector for extension type label. Please make sure you are running `gardener@v1.42` or later before enabling this.

@shafeeqes shafeeqes requested review from a team as code owners March 3, 2022 10:27
@gardener-robot gardener-robot added area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 3, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 3, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 3, 2022
MartinWeindel
MartinWeindel approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 3, 2022
@MartinWeindel MartinWeindel merged commit 5d8221c into gardener:master Mar 3, 2022
@shafeeqes shafeeqes deleted the enhancement/AdmissionWebhooks branch March 3, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shafeeqes @MartinWeindel @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot