Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop DNS activation for DNSOwner #171

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Drop DNS activation for DNSOwner #171

merged 1 commit into from
Nov 23, 2022

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area control-plane
/kind task

What this PR does / why we need it:
The deployment of the owner DNSRecord will be removed from Gardener (see gardener/gardener#7005) . Currently it is used as a second line of defend to activate the DNSOwner only, if the owner records contains the correct seed id.
This feature was introduced with PR #90.
With this PR the feature is removed again as it obsolete with the changes on Gardener side.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Drop DNS activation for DNSOwner.

@MartinWeindel MartinWeindel requested review from a team as code owners November 21, 2022 16:48
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/task General task size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 21, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2022
@MartinWeindel
Copy link
Member Author

rebase was needed

@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2022
@MartinWeindel MartinWeindel merged commit 30faab1 into master Nov 23, 2022
@MartinWeindel MartinWeindel deleted the drop-dns-activation branch November 23, 2022 08:54
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 23, 2022
@plkokanov plkokanov mentioned this pull request Mar 6, 2023
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandelsoft mandelsoft mandelsoft approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/task General task needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MartinWeindel @mandelsoft @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot