Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop vendoring #268

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Drop vendoring #268

merged 2 commits into from
Dec 18, 2023

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Dec 12, 2023 •
edited
Loading

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:
Remove vendoring from project

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Follows pattern in gardener/gardener-extension-provider-openstack#698

Release note:

Remove vendoring from project

Bump github.com/gardener/gardener from 1.85.0 to 1.86.0.

@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension needs/review Needs review labels Dec 12, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 12, 2023
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Dec 12, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 12, 2023
@MartinWeindel
refactoring after removing vendoring
61f93cd 
update gardener to v1.86.0
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 15, 2023
@MartinWeindel MartinWeindel marked this pull request as ready for review December 15, 2023 12:27
@MartinWeindel MartinWeindel requested review from a team as code owners December 15, 2023 12:27
ScheererJ
ScheererJ approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Dec 15, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 15, 2023
@MartinWeindel MartinWeindel merged commit 9eac7be into master Dec 18, 2023
6 checks passed
@MartinWeindel MartinWeindel deleted the drop-vendoring branch December 18, 2023 07:00
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 18, 2023
@MartinWeindel MartinWeindel mentioned this pull request Dec 18, 2023
Merged
@timuthy timuthy mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MartinWeindel @ScheererJ @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot