Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DNS provider type rfc2136 #313

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Allow DNS provider type rfc2136 #313

merged 1 commit into from
Mar 28, 2024

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Mar 28, 2024 •
edited

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
The dns-controller-manager supports the DNS provider type rfc2136 since v0.15.10, but the shoot-dns-service validation webhook rejects it as it does not know the new type.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
see gardener/external-dns-management#331

Release note:

Allow DNS provider type `rfc2136`

@MartinWeindel MartinWeindel requested review from a team as code owners March 28, 2024 11:52
@gardener-robot gardener-robot added needs/review Needs review area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 28, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 28, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 28, 2024
@MartinWeindel MartinWeindel mentioned this pull request Mar 28, 2024
Open
ScheererJ
ScheererJ approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 28, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 28, 2024
@MartinWeindel MartinWeindel merged commit f52ee63 into master Mar 28, 2024
6 checks passed
@MartinWeindel MartinWeindel deleted the enh/rfc2136 branch March 28, 2024 16:02
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MartinWeindel @ScheererJ @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot