Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add controlplane role to shoot-dns-service controller #37

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area control-plane robustness high-availability
/kind bug
/priority normal

What this PR does / why we need it:
shoot-dns-service controller has to be labelled as controlplane to be restarted by DependencyWatchDog if kube-apiserver recovers

Which issue(s) this PR fixes:
#36
see also https://github.com/gardener/gardener/issues/3679

Special notes for your reviewer:

Release note:


@MartinWeindel MartinWeindel requested review from a team as code owners March 8, 2021 14:46
@gardener-robot gardener-robot added area/control-plane Control plane related area/high-availability High availability related area/robustness Robustness, reliability, resilience related kind/bug Bug labels Mar 8, 2021
@gardener-robot
Copy link

@MartinWeindel Label priority/normal does not exist.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 8, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 8, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 8, 2021
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/invite @amshuman-kr

@gardener-robot gardener-robot removed the needs/review Needs review label Mar 8, 2021
Copy link
Collaborator

@amshuman-kr amshuman-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gardener-robot gardener-robot added needs/lgtm Needs approval for merging reviewed/lgtm Has approval for merging and removed needs/lgtm Needs approval for merging labels Mar 9, 2021
@timuthy timuthy merged commit 7838c1b into master Mar 9, 2021
@timuthy timuthy deleted the controlplane-role branch March 9, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related area/high-availability High availability related area/robustness Robustness, reliability, resilience related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants