no dns service installed if seed has taint disabledDNS #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
rfranzke
reviewed
Feb 25, 2020
pkg/controller/actuator.go
Outdated
| @@ -104,6 +107,12 @@ func (a *actuator) Reconcile(ctx context.Context, ex *extensionsv1alpha1.Extensi | |||
| return err | |||
| } | |||
|
|
|||
| if gardencorev1beta1helper.TaintsHave(cluster.Seed.Spec.Taints, gardencorev1beta1.SeedTaintDisableDNS) || | |||
| cluster.Shoot.Spec.DNS == nil { | |||
| a.logger.Info("no shoot dns service installed", "shoot", ex.Namespace) | |||
There was a problem hiding this comment.
maybe add the reason here so that readers of the logs know why :)
There was a problem hiding this comment.
already done, see commit below
There was a problem hiding this comment.
I was talking about the log message, not the comment in the code (which is also good to add, of course) :) - can you add it in the log msg as well + squash the commits?
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
MartinWeindel
force-pushed
the
feature/disabled-dns
branch
from
6d5b89c
to
82a912e
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
MartinWeindel
force-pushed
the
feature/disabled-dns
branch
from
82a912e
to
dcff5f4
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
ialidzhikov
pushed a commit
to ialidzhikov/gardener-extension-shoot-dns-service
that referenced
this pull request
Mar 14, 2020
[ci:component:github.com/gardener/cert-management:v0.2.13->v0.2.14]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4
Special notes for your reviewer:
Release note: