Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only perform health check if DNS is enabled #8

Merged
merged 1 commit into from Mar 23, 2020
Merged

Only perform health check if DNS is enabled #8

merged 1 commit into from Mar 23, 2020

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Mar 22, 2020 •
edited

What this PR does / why we need it:
If the shoot's DNS is disabled then no health checks will be performed.

Special notes for your reviewer:
✅ Depends on gardener-attic/gardener-extensions#627 + revendoring

Release note:

The health checks are no longer executed for shoots with disabled DNS.

@rfranzke rfranzke added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Mar 22, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 22, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 22, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 23, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 23, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 23, 2020
@rfranzke rfranzke removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Mar 23, 2020
@rfranzke rfranzke marked this pull request as ready for review March 23, 2020 11:13
@rfranzke rfranzke requested review from a team as code owners March 23, 2020 11:13
@rfranzke
Copy link
Member Author

PR is ready for review, PTAL @gardener/gardener-extension-shoot-dns-service-maintainers

@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 23, 2020
ialidzhikov
ialidzhikov reviewed Mar 23, 2020
View reviewed changes
go.mod Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 23, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 23, 2020
ialidzhikov
ialidzhikov approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

MartinWeindel
MartinWeindel approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@MartinWeindel MartinWeindel merged commit 953d9ef into gardener:master Mar 23, 2020
@rfranzke rfranzke deleted the fix/healthcheck branch March 23, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

@ialidzhikov ialidzhikov ialidzhikov approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rfranzke @MartinWeindel @ialidzhikov @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3