Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt high-availability configuration #37

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Adapt high-availability configuration #37

merged 1 commit into from
Nov 21, 2022

Conversation

timuthy
Copy link
Contributor

@timuthy timuthy commented Nov 21, 2022

How to categorize this PR?

/area high-availability
/kind enhancement

What this PR does / why we need it:
This PR prepares the extension controller for HA by labeling it with high-availability-config.resources.gardener.cloud/type: controller and defining the required PodDisruptionBudget, please see this document for more information.

Which issue(s) this PR fixes:
Part of gardener/gardener#6529

Special notes for your reviewer:
The network problem detector controller can only be made highly available when gardener/network-problem-detector#20 is solved.

Release note:

The extension controller has been adjusted to the high availability configuration supported by Gardener as of release `v1.60`. See [this document](https://github.com/gardener/gardener/blob/master/docs/development/high-availability.md) for more information about HA in gardener.

@timuthy timuthy requested a review from a team as a code owner November 21, 2022 09:20
@gardener-robot gardener-robot added area/high-availability High availability related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 21, 2022
@timuthy timuthy mentioned this pull request Nov 21, 2022
Closed
56 tasks
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2022
MartinWeindel
MartinWeindel approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 21, 2022
@MartinWeindel MartinWeindel merged commit f2707d8 into gardener:main Nov 21, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/high-availability High availability related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timuthy @MartinWeindel @gardener-robot-ci-3 @gardener-robot