Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to network-problem-detector v0.9.0 and updated dependencies #40

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Adapt to network-problem-detector v0.9.0 and updated dependencies #40

merged 1 commit into from
Nov 24, 2022

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented Nov 24, 2022 •
edited

What this PR does / why we need it:
Added leader election to deployment of NWPD controller.

Updated builder image to golang version v1.19.3.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Part of gardener/gardener#6529

Release note:

Added leader election to deployment of NWPD controller.

Updated builder image from golang version `v1.19.1` to `v1.19.3`.

@MartinWeindel MartinWeindel requested a review from a team as a code owner November 24, 2022 09:09
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 24, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 24, 2022
ScheererJ
ScheererJ approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 24, 2022
@MartinWeindel MartinWeindel merged commit 8fddaab into main Nov 24, 2022
@MartinWeindel MartinWeindel deleted the adapt-to-nwpd-0.9 branch November 24, 2022 09:17
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MartinWeindel @ScheererJ @gardener-robot-ci-2 @gardener-robot