-
Notifications
You must be signed in to change notification settings - Fork 474
/
generate.go
533 lines (446 loc) · 17 KB
/
generate.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
// Copyright 2022 SAP SE or an SAP affiliate company. All rights reserved. This file is licensed under the Apache Software License, v. 2 except as noted otherwise in the LICENSE file
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package manager
import (
"context"
"fmt"
"strconv"
"strings"
"time"
corev1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/utils/pointer"
"sigs.k8s.io/controller-runtime/pkg/client"
"github.com/gardener/gardener/pkg/utils"
kubernetesutils "github.com/gardener/gardener/pkg/utils/kubernetes"
secretsutils "github.com/gardener/gardener/pkg/utils/secrets"
)
func (m *manager) Generate(ctx context.Context, config secretsutils.ConfigInterface, opts ...GenerateOption) (*corev1.Secret, error) {
options := &GenerateOptions{}
if err := options.ApplyOptions(m, config, opts); err != nil {
return nil, err
}
var bundleFor *string
if options.isBundleSecret {
bundleFor = pointer.String(strings.TrimSuffix(config.GetName(), nameSuffixBundle))
}
objectMeta, err := ObjectMeta(
m.namespace,
m.identity,
config,
options.IgnoreConfigChecksumForCASecretName,
m.lastRotationInitiationTimes[config.GetName()],
options.signingCAChecksum,
&options.Persist,
bundleFor,
)
if err != nil {
return nil, err
}
desiredLabels := utils.MergeStringMaps(objectMeta.Labels) // copy labels map
secret := &corev1.Secret{}
if err := m.client.Get(ctx, kubernetesutils.Key(objectMeta.Namespace, objectMeta.Name), secret); err != nil {
if !apierrors.IsNotFound(err) {
return nil, err
}
secret, err = m.generateAndCreate(ctx, config, objectMeta)
if err != nil {
return nil, err
}
}
if err := m.maintainLifetimeLabels(config, secret, desiredLabels, options.Validity); err != nil {
return nil, err
}
if !options.isBundleSecret {
if err := m.addToStore(config.GetName(), secret, current); err != nil {
return nil, err
}
if ignore, err := m.shouldIgnoreOldSecrets(desiredLabels[LabelKeyIssuedAtTime], options); err != nil {
return nil, err
} else if !ignore {
if err := m.storeOldSecrets(ctx, config.GetName(), secret.Name); err != nil {
return nil, err
}
}
if err := m.generateBundleSecret(ctx, config); err != nil {
return nil, err
}
}
if err := m.reconcileSecret(ctx, secret, desiredLabels); err != nil {
return nil, err
}
return secret, nil
}
func (m *manager) generateAndCreate(ctx context.Context, config secretsutils.ConfigInterface, objectMeta metav1.ObjectMeta) (*corev1.Secret, error) {
// Use secret name as common name to make sure the x509 subject names in the CA certificates are always unique.
if certConfig := certificateSecretConfig(config); certConfig != nil && certConfig.CertType == secretsutils.CACert {
certConfig.CommonName = objectMeta.Name
}
data, err := config.Generate()
if err != nil {
return nil, err
}
dataMap, err := m.keepExistingSecretsIfNeeded(ctx, config.GetName(), data.SecretData())
if err != nil {
return nil, err
}
secret := Secret(objectMeta, dataMap)
if err := m.client.Create(ctx, secret); err != nil {
if !apierrors.IsAlreadyExists(err) {
return nil, err
}
if err := m.client.Get(ctx, client.ObjectKeyFromObject(secret), secret); err != nil {
return nil, err
}
}
m.logger.Info("Generated new secret", "configName", config.GetName(), "secretName", secret.Name)
return secret, nil
}
func (m *manager) keepExistingSecretsIfNeeded(ctx context.Context, configName string, newData map[string][]byte) (map[string][]byte, error) {
existingSecrets := &corev1.SecretList{}
if err := m.client.List(ctx, existingSecrets, client.InNamespace(m.namespace), client.MatchingLabels{LabelKeyUseDataForName: configName}); err != nil {
return nil, err
}
if len(existingSecrets.Items) > 1 {
return nil, fmt.Errorf("found more than one existing secret with %q label for config %q", LabelKeyUseDataForName, configName)
}
if len(existingSecrets.Items) == 1 {
return existingSecrets.Items[0].Data, nil
}
return newData, nil
}
func (m *manager) shouldIgnoreOldSecrets(issuedAt string, options *GenerateOptions) (bool, error) {
// unconditionally ignore old secrets
if options.RotationStrategy != KeepOld || options.IgnoreOldSecrets {
return true, nil
}
// ignore old secrets if current secret is older than IgnoreOldSecretsAfter
if options.IgnoreOldSecretsAfter != nil {
if issuedAt == "" {
// should never happen
return false, nil
}
issuedAtUnix, err := strconv.ParseInt(issuedAt, 10, 64)
if err != nil {
return false, err
}
age := m.clock.Now().UTC().Sub(time.Unix(issuedAtUnix, 0).UTC())
if age >= *options.IgnoreOldSecretsAfter {
return true, nil
}
}
return false, nil
}
func (m *manager) storeOldSecrets(ctx context.Context, name, currentSecretName string) error {
secretList := &corev1.SecretList{}
if err := m.client.List(ctx, secretList, client.InNamespace(m.namespace), client.MatchingLabels{
LabelKeyName: name,
LabelKeyManagedBy: LabelValueSecretsManager,
LabelKeyManagerIdentity: m.identity,
}); err != nil {
return err
}
var oldSecret *corev1.Secret
for _, secret := range secretList.Items {
if secret.Name == currentSecretName {
continue
}
if oldSecret == nil || oldSecret.CreationTimestamp.Time.Before(secret.CreationTimestamp.Time) {
oldSecret = secret.DeepCopy()
}
}
if oldSecret == nil {
return nil
}
return m.addToStore(oldSecret.Labels[LabelKeyName], oldSecret, old)
}
func (m *manager) generateBundleSecret(ctx context.Context, config secretsutils.ConfigInterface) error {
var bundleConfig secretsutils.ConfigInterface
secrets, found := m.getFromStore(config.GetName())
if !found {
return fmt.Errorf("secrets for name %q not found in internal store", config.GetName())
}
switch c := config.(type) {
case *secretsutils.CertificateSecretConfig:
if c.SigningCA == nil {
certs := [][]byte{secrets.current.obj.Data[secretsutils.DataKeyCertificateCA]}
if secrets.old != nil {
certs = append(certs, secrets.old.obj.Data[secretsutils.DataKeyCertificateCA])
}
bundleConfig = &secretsutils.CertificateBundleSecretConfig{
Name: config.GetName() + nameSuffixBundle,
CertificatePEMs: certs,
}
}
case *secretsutils.RSASecretConfig:
if !c.UsedForSSH {
keys := [][]byte{secrets.current.obj.Data[secretsutils.DataKeyRSAPrivateKey]}
if secrets.old != nil {
keys = append(keys, secrets.old.obj.Data[secretsutils.DataKeyRSAPrivateKey])
}
bundleConfig = &secretsutils.RSAPrivateKeyBundleSecretConfig{
Name: config.GetName() + nameSuffixBundle,
PrivateKeyPEMs: keys,
}
}
}
if bundleConfig == nil {
return nil
}
secret, err := m.Generate(ctx, bundleConfig, isBundleSecret())
if err != nil {
return err
}
return m.addToStore(config.GetName(), secret, bundle)
}
func (m *manager) maintainLifetimeLabels(
config secretsutils.ConfigInterface,
secret *corev1.Secret,
desiredLabels map[string]string,
validity time.Duration,
) error {
issuedAt := secret.Labels[LabelKeyIssuedAtTime]
if issuedAt == "" {
issuedAt = unixTime(m.clock.Now())
}
desiredLabels[LabelKeyIssuedAtTime] = issuedAt
if validity > 0 {
desiredLabels[LabelKeyValidUntilTime] = unixTime(m.clock.Now().Add(validity))
// Handle changed validity values in case there already is a valid-until-time label from previous Generate
// invocations.
if secret.Labels[LabelKeyValidUntilTime] != "" {
issuedAtTime, err := strconv.ParseInt(issuedAt, 10, 64)
if err != nil {
return err
}
existingValidUntilTime, err := strconv.ParseInt(secret.Labels[LabelKeyValidUntilTime], 10, 64)
if err != nil {
return err
}
if oldValidity := time.Duration(existingValidUntilTime - issuedAtTime); oldValidity != validity {
desiredLabels[LabelKeyValidUntilTime] = unixTime(time.Unix(issuedAtTime, 0).UTC().Add(validity))
// If this has yielded a valid-until-time which is in the past then the next instantiation of the
// secrets manager will regenerate the secret since it has expired.
}
}
}
var dataKeyCertificate string
switch cfg := config.(type) {
case *secretsutils.CertificateSecretConfig:
dataKeyCertificate = secretsutils.DataKeyCertificate
if cfg.CertType == secretsutils.CACert {
dataKeyCertificate = secretsutils.DataKeyCertificateCA
}
case *secretsutils.ControlPlaneSecretConfig:
if cfg.CertificateSecretConfig == nil {
return nil
}
dataKeyCertificate = secretsutils.ControlPlaneSecretDataKeyCertificatePEM(config.GetName())
default:
return nil
}
certificate, err := utils.DecodeCertificate(secret.Data[dataKeyCertificate])
if err != nil {
return fmt.Errorf("error decoding certificate when trying to maintain lifetime labels: %w", err)
}
desiredLabels[LabelKeyIssuedAtTime] = unixTime(certificate.NotBefore)
desiredLabels[LabelKeyValidUntilTime] = unixTime(certificate.NotAfter)
return nil
}
func (m *manager) reconcileSecret(ctx context.Context, secret *corev1.Secret, labels map[string]string) error {
patch := client.MergeFrom(secret.DeepCopy())
var mustPatch bool
if secret.Immutable == nil || !*secret.Immutable {
secret.Immutable = pointer.Bool(true)
mustPatch = true
}
// Check if desired labels must be added or changed.
for k, desired := range labels {
if current, ok := secret.Labels[k]; !ok || current != desired {
metav1.SetMetaDataLabel(&secret.ObjectMeta, k, desired)
mustPatch = true
}
}
// Check if existing labels must be removed
for k := range secret.Labels {
if _, ok := labels[k]; !ok {
delete(secret.Labels, k)
mustPatch = true
}
}
if !mustPatch {
return nil
}
return m.client.Patch(ctx, secret, patch)
}
// GenerateOption is some configuration that modifies options for a Generate request.
type GenerateOption func(Interface, secretsutils.ConfigInterface, *GenerateOptions) error
// GenerateOptions are options for Generate calls.
type GenerateOptions struct {
// Persist specifies whether the 'persist=true' label should be added to the secret resources.
Persist bool
// RotationStrategy specifies how the secret should be rotated in case it needs to get rotated.
RotationStrategy rotationStrategy
// IgnoreOldSecrets specifies whether old secrets should be dropped.
IgnoreOldSecrets bool
// IgnoreOldSecretsAfter specifies that old secrets should be dropped once a given duration after rotation has passed.
IgnoreOldSecretsAfter *time.Duration
// Validity specifies for how long the secret should be valid.
Validity time.Duration
// IgnoreConfigChecksumForCASecretName specifies whether the secret config checksum should be ignored when
// computing the secret name for CA secrets.
IgnoreConfigChecksumForCASecretName bool
signingCAChecksum *string
isBundleSecret bool
}
type rotationStrategy string
const (
// InPlace is a constant for a rotation strategy regenerating a secret and NOT keeping the old one in the system.
InPlace rotationStrategy = "inplace"
// KeepOld is a constant for a rotation strategy regenerating a secret and keeping the old one in the system.
KeepOld rotationStrategy = "keepold"
)
// ApplyOptions applies the given update options on these options, and then returns itself (for convenient chaining).
func (o *GenerateOptions) ApplyOptions(manager Interface, configInterface secretsutils.ConfigInterface, opts []GenerateOption) error {
for _, opt := range opts {
if err := opt(manager, configInterface, o); err != nil {
return err
}
}
return nil
}
// SignedByCAOption is some configuration that modifies options for a SignedByCA request.
type SignedByCAOption interface {
// ApplyToOptions applies this configuration to the given options.
ApplyToOptions(*SignedByCAOptions)
}
// SignedByCAOptions are options for SignedByCA calls.
type SignedByCAOptions struct {
// CAClass specifies which CA should be used to sign the requested certificate. Server certificates are signed with
// the old CA by default, however one might want to use the current CA instead. Similarly, client certificates are
// signed with the current CA by default, however one might want to use the old CA instead.
CAClass *secretClass
}
// ApplyOptions applies the given update options on these options, and then returns itself (for convenient chaining).
func (o *SignedByCAOptions) ApplyOptions(opts []SignedByCAOption) *SignedByCAOptions {
for _, opt := range opts {
opt.ApplyToOptions(o)
}
return o
}
var (
// UseCurrentCA sets the CAClass field to 'current' in the SignedByCAOptions.
UseCurrentCA = useCAClassOption{current}
// UseOldCA sets the CAClass field to 'old' in the SignedByCAOptions.
UseOldCA = useCAClassOption{old}
)
type useCAClassOption struct {
class secretClass
}
func (o useCAClassOption) ApplyToOptions(options *SignedByCAOptions) {
options.CAClass = &o.class
}
// SignedByCA returns a function which sets the 'SigningCA' field in case the ConfigInterface provided to the
// Generate request is a CertificateSecretConfig. Additionally, in such case it stores a checksum of the signing
// CA in the options.
func SignedByCA(name string, opts ...SignedByCAOption) GenerateOption {
signedByCAOptions := &SignedByCAOptions{}
signedByCAOptions.ApplyOptions(opts)
return func(m Interface, config secretsutils.ConfigInterface, options *GenerateOptions) error {
mgr, ok := m.(*manager)
if !ok {
return nil
}
certificateConfig := certificateSecretConfig(config)
if certificateConfig == nil {
return fmt.Errorf("could not apply option to %T, expected *secrets.CertificateSecretConfig", config)
}
secrets, found := mgr.getFromStore(name)
if !found {
return fmt.Errorf("secrets for name %q not found in internal store", name)
}
secret := secrets.current
switch certificateConfig.CertType {
case secretsutils.ClientCert:
// Client certificates are signed with the current CA by default unless the CAClass option was overwritten.
if signedByCAOptions.CAClass != nil && *signedByCAOptions.CAClass == old && secrets.old != nil {
secret = *secrets.old
}
case secretsutils.ServerCert, secretsutils.ServerClientCert:
// Server certificates are signed with the old CA by default (if it exists) unless the CAClass option was
// overwritten.
if secrets.old != nil && (signedByCAOptions.CAClass == nil || *signedByCAOptions.CAClass != current) {
secret = *secrets.old
}
}
ca, err := secretsutils.LoadCertificate(name, secret.obj.Data[secretsutils.DataKeyPrivateKeyCA], secret.obj.Data[secretsutils.DataKeyCertificateCA])
if err != nil {
return err
}
certificateConfig.SigningCA = ca
options.signingCAChecksum = pointer.String(kubernetesutils.TruncateLabelValue(secret.dataChecksum))
return nil
}
}
// Persist returns a function which sets the 'Persist' field to true.
func Persist() GenerateOption {
return func(_ Interface, _ secretsutils.ConfigInterface, options *GenerateOptions) error {
options.Persist = true
return nil
}
}
// Rotate returns a function which sets the 'RotationStrategy' field to the specified value.
func Rotate(strategy rotationStrategy) GenerateOption {
return func(_ Interface, _ secretsutils.ConfigInterface, options *GenerateOptions) error {
options.RotationStrategy = strategy
return nil
}
}
// IgnoreOldSecrets returns a function which sets the 'IgnoreOldSecrets' field to true.
func IgnoreOldSecrets() GenerateOption {
return func(_ Interface, _ secretsutils.ConfigInterface, options *GenerateOptions) error {
options.IgnoreOldSecrets = true
return nil
}
}
// IgnoreOldSecretsAfter returns a function which sets the 'IgnoreOldSecretsAfter' field to the given duration.
func IgnoreOldSecretsAfter(d time.Duration) GenerateOption {
return func(_ Interface, _ secretsutils.ConfigInterface, options *GenerateOptions) error {
options.IgnoreOldSecretsAfter = &d
return nil
}
}
// Validity returns a function which sets the 'Validity' field to the provided value. Note that the value is ignored in
// case Generate is called with a certificate secret configuration.
func Validity(v time.Duration) GenerateOption {
return func(_ Interface, _ secretsutils.ConfigInterface, options *GenerateOptions) error {
options.Validity = v
return nil
}
}
// IgnoreConfigChecksumForCASecretName returns a function which sets the 'IgnoreConfigChecksumForCASecretName' field to
// true.
func IgnoreConfigChecksumForCASecretName() GenerateOption {
return func(_ Interface, _ secretsutils.ConfigInterface, options *GenerateOptions) error {
options.IgnoreConfigChecksumForCASecretName = true
return nil
}
}
func isBundleSecret() GenerateOption {
return func(_ Interface, _ secretsutils.ConfigInterface, options *GenerateOptions) error {
options.isBundleSecret = true
return nil
}
}