-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling scheduled backup compaction for ETCD via gardenlet feature gate #4511
Comments
/assign @abdasgupta |
How about using an annotation on the Shoot resource for this? |
TBH, I don't think a gardenlet feature gate is the correct implementation. You can simply expose some etcd-druid configuration options via the gardenlet config, just like it is done for the logging and SNI gardener/pkg/gardenlet/apis/config/v1alpha1/types.go Lines 75 to 82 in 0bb7e58
|
@abdasgupta @timuthy Do you still plan to have such feature gate? In the recent PRs, I think etcd backup compaction can be configured via gardenlet configuration, is this enough? |
Thanks for reminding @rfranzke. You're right, we discussed this option internally and decided to go with the typical options instead of introducing a feature gate because they usually come with a graduation plan, i.e. the feature gate itself will eventually be removed again. But compaction should be turned on/off by operators if they see demand for it, so it's independent from the graduation state. |
/close |
Great, thank you! |
How to categorize this issue?
/area control-plane cost high-availability disaster-recovery
/kind enhancement
/priority 2
What would you like to be added:
The upcoming release of
etcd-druid
includes the feature to schedule periodic compaction of incremental snapshots in the ETCD backup. This feature improves the disaster-recovery behaviour by setting an upper limit to the time taken to restore ETCDs from backup.However, enabling this for all ETCDs in the landscape might incur additional cost especially in network traffic.
To gain more control over the rollout of this feature, it would be good to introduce a new
gardenlet
feature gate (say,ETCDBackupCompaction
) so that the feature can be enabled only in the soil clusters first (to gain control over the ETCD restoration time for the seed ETCDs) and only later in other seed clusters if there is a need.Further,
purpose
field in theShoot
spec)?cc @dguendisch @dkistner @mliepold @ashwani2k
Why is this needed:
ETCD restoration time can be quite long (
45m
to1h
or even longer) if there are a lot of incremental snapshots to be applied during restoration (the incremental snapshots can only be applied sequentially).This affects larger shoot clusters where the number of changes flowing into the ETCD is quite large (such as seed clusters).
The text was updated successfully, but these errors were encountered: